Feature #2360 Contributor's Guide - MET unit tests #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de and add scripts to help handle unit test input data for use in automated tests
22 tasks
17 tasks
There was a problem hiding this comment.
Thanks for making these changes George. I proposed some edits to the documentation. I note that I have not actually tested the scripts to confirm that they work as expected, but plan to rely on the testing you've already performed.
Please accept/reject my proposed edits as you see fit and re-request my review.
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
JohnHalleyGotway
previously approved these changes
Apr 3, 2025
There was a problem hiding this comment.
I read through the updates and confirmed that the formatting is rendering well on RTD. I approve. Thanks for all your work on this.
jprestop
reviewed
Apr 3, 2025
jprestop
reviewed
Apr 3, 2025
jprestop
previously approved these changes
Apr 3, 2025
There was a problem hiding this comment.
This is great, @georgemccabe. Thank you for all of your work on this! I made two suggestions.
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
1662123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add scripts to help handle unit test input data for use in automated tests
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Ran scripts on mohawk to ensure they work as expected: Created directory for v12.1 and added data needed for #2794
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by 4/4/2025.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release