Skip to content

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Feb 14, 2025

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Confirmed that these changes compile and ran the test_config development utility to make sure that both empty and non-empty config files parse well.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review this in conjunction with Bugfix #3077 main_v12.0 yyerror #3083 to fix this bug in the main_v12.0 branch. This PR includes the same changes, but also:

  • Updates config.tab.yy and color_parse_yacc.yy to...

    • Address SonarQube code smell recommendations of declaring each variable on their own line and limiting their scope.
    • Apply consistent code formatting.
    • Use consistent formatting of error messages.
  • Note that the diffs flagged in config.tab.h, config.tab.cc, color_parser_yacc.h, color_parser_yacc.cc, and Makefile.in are all in auto-generated code that can be ignored. The only real changes are in config.tab.yy, color_parser_yacc.yy, and Makefile.am.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    None needed.

  • Do these changes include sufficient testing updates? [Yes]
    None needed.

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:
    While some code smells are flagged as being in new code, the overall number of code smells are reduced by 29, from 17,545 in develop to 17,516 for this PR.

  • Please complete this pull request review by [Tuesday 2/18/25].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…c reserves %type to nonterminals [-Wyacc]'
…ame way we allow for them in config.tab.yy. Also use the opportunity to refine the code based on SonarQube feedback - removing commented out code and declaring variables on dedicated lines.
…for MET #2408 with a yystate patch in Makefile.am that was causing other intermittent failures. Update config.tab.yy to allow for empty inputs in the statement_list rule.
…ells of having each variable declared on its own line.
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.1.0 milestone Feb 14, 2025
@JohnHalleyGotway JohnHalleyGotway linked an issue Feb 14, 2025 that may be closed by this pull request
23 tasks
@JohnHalleyGotway JohnHalleyGotway marked this pull request as ready for review February 14, 2025 21:07
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes as #3083 but with a few additional cleanup items.

@JohnHalleyGotway JohnHalleyGotway merged commit 9c17704 into develop Feb 14, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix intermittent configuration string parsing yyerror failure
2 participants