Bugfix #3077 develop yyerror #3084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Confirmed that these changes compile and ran the
test_config
development utility to make sure that both empty and non-empty config files parse well.Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review this in conjunction with Bugfix #3077 main_v12.0 yyerror #3083 to fix this bug in the main_v12.0 branch. This PR includes the same changes, but also:
Updates
config.tab.yy
andcolor_parse_yacc.yy
to...Note that the diffs flagged in
config.tab.h
,config.tab.cc
,color_parser_yacc.h
,color_parser_yacc.cc
, andMakefile.in
are all in auto-generated code that can be ignored. The only real changes are inconfig.tab.yy
,color_parser_yacc.yy
, andMakefile.am
.Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
None needed.
Do these changes include sufficient testing updates? [Yes]
None needed.
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
While some code smells are flagged as being in new code, the overall number of code smells are reduced by 29, from 17,545 in
develop
to 17,516 for this PR.Please complete this pull request review by [Tuesday 2/18/25].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases