Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 23, 2024

Adds units attribute to gen_vx_mask output and also adds 2 new output files.

ERROR: folder /data/output/met_test_truth missing 2 files
gen_vx_mask/DATA_DATA_LAT_LON_mask.nc
gen_vx_mask/SOLAR_MIDNIGHT_NH.nc <br/>Created by @JohnHalleyGotway

Howard Soh and others added 30 commits February 2, 2024 16:58
* Per #2395, add new columns to VL1L2, VAL1L2, and VCNT line types for wind direction statistics. Work still in progress.

* Per #2395, write the new VCNT columns to the output and document the additions to the VL1L2, VAL1L2, and VCNT columns.

* Per #2395, add the definition of new statistics to Appendix G.

* Per #2395, update file version history.

* Per #2395, tweak warning message about zero wind vectors and update grid-stat and point-stat to log calls to the do_vl1l2() function.

* Per #2395, refine the weights for wind direction stats, ignoring the undefined directions.

* Update src/tools/core/stat_analysis/aggr_stat_line.cc

* Update src/tools/core/stat_analysis/parse_stat_line.cc

* Update src/tools/core/stat_analysis/aggr_stat_line.cc
… broken the logic of the update_truth.yml GHA workflow. Instead of submitting a PR to merge develop into develop-ref directly, use an intermediate update_truth_for_develop branch.
* Per #2280, update to support probability threshold strings like ==8, where 8 is the number of ensemble members, to create probability bins centered on the n/8 for n = 0 ... 8.

* Per #2280, update docs about probability threshold settings.

* Per #2280, use a loose tolerance when checking for consistent bin widths.

* Per #2280, add a new unit test for grid_stat to demonstrate processing the output from gen_ens_prod.

* Per #2280, when verifying NMEP probability forecasts, smooth the obs data first.

* Per #2280, only request STAT output for the PCT line type to match unit_grid_stat.xml and minimize the new output files.

* Per #2280, update config option docs.

* Per #2280, update config option docs.
…ullptr

Feature 2673 sonarqube beta4 nullptr
…eturn

Feature 2673 sonarqube beta4 return
JohnHalleyGotway and others added 27 commits October 16, 2024 14:08
* Per #2893, add obtype_as_obs_message_type_flag option for Point-Stat and Ensemble-Stat that applies when writing MPR, SEEPS_MPR, and ORANK line types. If true, write the input observation message type to the OBTYPE output column rather than the name of the group.

* Per #2893, add option to default config files and fix compilation errors.

* Per #2893, change the name from obtype_as_obs_message_type_flag to obtype_as_group_val_flag.

* Per #2893, add docs ci-run-unit

* Per #2893, add obtype_as_group_val_flag entry for all config files that already include the message_type_group_map entry.

* Per #2893, modify existing PointStatConfig_WINDS config file to have it write MPR output with obtype_as_group_val_flag = TRUE. Note that I switched the message types from ADPSFC, SFCSHP, USERSF to just USERSF. The original reason for the 3 was to prove that the counts for ADPSFC + SFCSHP = USERSF.

* Per #2893, update commit history for ensemble_stat and point_stat

* Per #2893, revert back PointStatConfig_WINDS to minimize diffs

* Per #2893, add a Point-Stat unit test to demonstrate setting the obtype_as_group_val_flag option.

* Per #2893, need to reset the obtype after writing all MPR, SEEPS_MPR, and ORANK line types in Point-Stat

* Per #2893, tweak Point-Stat configuration to also write HIRA ORANK and PCT outputs.
* #2673 SonarQube findings: use vector for the dynamic memory allocation

* #2673 Check if a vector is allocated

* #2673 Check if a vector is allocated

* #2673 SonarQube findings use vector

* #2673 Resolved SonarQube findingds

* #2673 SonarQube: Replaced f-strings to regular strings

* #2673 Added staticmethod  to read_mpr

* #2673 SonarQube: removed unnecessary pass

* #2673 SonarQube: use vector

* #2673 Initialize vecvgtor variables

* 673 Check if an user python command is empty

* #2673 Changed 0 to nullptr

* #2673 Rollback for s and av

* #2673 Applied the static method call

* #2673 Rollback using vector because of introducing a bug

* 673 Cleanup commented out code

---------

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
* Per #2996, add beta6 release notes.

* Per #2996, slight change in order

* Update docs/Users_Guide/release-notes.rst

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* Per #2673, switch to STL vector to attempt to squash a SonarQube bug.

* Per #2673, remove m_strlen() entirely.

* Per #2673, try again ci-skip-unit

* Per #2673, switching to 2 more vectors
* Per #3000, change 9 warning messages to Debug(2) log messages to minimize the number of warning messages Point2Grid writes. However, do retain the warnings about problems writing the grid mapping output file.

* Per #3000 very minor whitespace diffs
* Per #2631, regenerate ndbc_stations.xml for MET-12.0.0 on October 22, 2024.

* Per #2631, add MET_BASE anchor

* Per #2631, add a description of some of the static data files that need to be periodically updated. Note that this is NOT an exhaustive list.

* Per #2631, consistent wording

* Per #2631, subset by update frequency.

* Per #2631, consistent wording. Fix typos.

* Per #2631, fix typo and URL

* Per #2631, fix masked array error in the get_precision(...) function I encountered when using the utility to inspect the diffs for this PR.
…-16 and GOES-17 with GOES-East and GOES-West in the MET User's Guide.
* Per #2780, grib2_bom.txt only has minor change replacing 'Prelim:' with 'Prelim'

* Per #2780, grib2_tigge.txt add new table after eliminating whitespace from units strings

* Per #2780, grib2_all.txt increase the number of entries from 1019 to 1570.

* Per #2780, grib2_kma.txt add new grib2 table file.

* Per #2780, carefully merge the existing 175 MRMS GRIB2 table entries with updates from the 109 defined in the wgrib2 table.

* Per #2780, grib2_ecmwf.txt add new ECMWF GRIB2 table.

* Per #2780, grib2_dwd.txt add new DWD GRIB2 table.

* Per #2870, correct units out of order

* Per #2870, grib2_gpp_af.txt elimiate embedded whitespace from units string to avoid problems writing them to FCST_UNITS and OBS_UNITS output columns

* Per #2780, grib2_ecmwf.txt eliminate whitespace from units string

* Per #2780, add/update GRIB2 tables

* Per #2870, remove duplicate entries I'd added.

* Per #2870, grib2_all.txt update with more entries from this version of wgrib2: hera:/home/Wesley.Ebisuzaki/grib2/wgrib2/gribtables/ncep/gribtable.dat

* Per #2780, grib2_mrms.txt add entries for FRANA as requested by @MarcelCaron-NOAA.

* Per #2780, add new grib1_jra_55_200.txt file that did not previously exist for MET.

* Per #2780, remove embedded whitespace from GRIB1 DWD tables.

* Per #2780, fix all the units by removing embedded whitespace and making them more human-readable by replacing ** with ^ to indicate exponentiation. Also correct bad units for radiation flux in AF tables by listing them as W/m^2.

* Per #2780 eliminate trailing whitespace

* Per #2870, fix typo

* Per #2870, fix typos

* Per #2870, fix typo

* Per #2780, grib1_ncep_129_7.txt fix units by replacing '&micro;g' with 'mcg' to represent micrograms. Also replace 'mm6' with 'mm^6' by double-checking against the GRIB1 docs.

* Per #2780, switch to defining particulate matter units as '10^-6g/m^3' for consistent usage across NCEP GRIB tables.

* Per #2780, update GRIB2 units to show exponentiation correctly by comparing against documentation at https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc

* Per #2780, more tweaks for consistent and corrected units

* Per #2780, update Makefiles for new grib1_jra55_200.txt file

* Per #2870, more tweaks for consistent formatting of units to eliminate the use of parantheses in the denominator. For example, replace 'kg/(m*s)' with 'kg/m/s'.
* Per #2729, get rid of extra blank line in log message about manually deleting temp files.

* Per #2729, fix log message describing the range/azimuth grid.

* Per #2729, Update TC-Diag Python driver code to convert rotation angles from degree clockwise from due East to radians counter-clockwise from due East.

* Per #2729, complete the TC-Diag documentation.

* Per #2729, more tweaks

* Per #2729, clarify that some diagnostics are directly extracted from the ATCF track file rather than being computed from the cylindrical coordinates grid.

* Update docs/Users_Guide/tc-diag.rst

Co-authored-by: KathrynNewman <knewman@ucar.edu>

* Update docs/Users_Guide/tc-diag.rst

Co-authored-by: KathrynNewman <knewman@ucar.edu>

* Update docs/Users_Guide/tc-diag.rst

Co-authored-by: KathrynNewman <knewman@ucar.edu>

* Update docs/Users_Guide/tc-diag.rst

Co-authored-by: KathrynNewman <knewman@ucar.edu>

* Update docs/Users_Guide/tc-diag.rst

Co-authored-by: KathrynNewman <knewman@ucar.edu>

---------

Co-authored-by: KathrynNewman <knewman@ucar.edu>
* Per #2750, user-provided should be hyphenated.

* Per #2750, add units to MTD output tables and specify order of forecast minus observation differences, where applicable. Also update some wording for consistency.

* Unrelated to #2750, but prior to the v12.0.0 release, create a 12.0.0 flowchart, save as PNG, and use it to update the overview figure.

* Per #2750, put X_DOT and Y_DOT back on separate lines since RTD interprets X_,Y_DOT as being a poorly defined link.
* Update data_io.rst

Updated netCDF reading documentation

* Update data_io.rst

* Update data_io.rst

* Update data_io.rst

updated link

* Update data_io.rst

Fixed typo
* Per #3015, update the release version number and add release notes.

* Per #3015, add one upgrade instruction
* Per #3020, add missing GridStatNcOutInfo::do_seeps flag and use it to determine if SEEPS information should be written to the Grid-Stat NetCDF matched pairs output file.

* Unrelated to #3020, fix broken NetCDF cf-conventions links in the User's Guide.

* Per #3020, no real changes. Just whitespace
…idStatConfig_SEEPS config file needs to be updated with nc_pairs_flag.seeps = TRUE in order for the same output to be produced by the unit tests.
* Per #2966, add new solar_time() function to the vx_solar library.

* Per #2966, add support for new solar_time masking type. Also make log messages for consistent and eliminate the warning about -thresh not being specified becuase its fine to not specify a threshold.

* Per #2966, add a units attribute to the output NetCDF mask variable.

* Per #2966, modify solar azimuth and altitude strings to make the log messages align well.

* Per #2966, add gen_vx_mask unit test to demonstrate the solar_time masking type.

* Per #2966, add documentation about the -solar_time option

* Per #2966, reduce SonarQube code smells in gen_vx_mask

* Per #2966, reduce SonarQube findings

* Per #2966, support multiple mask types with the same mask field being supported in a single run. Still need to update the user's guide.

* Per #2966, add UTC

* Per #2966, update gen_vx_mask docs about supporting multiple -type options in a single run

* Per #2966, update logic to fix using data masking twice, add a unit test to demonstrate, and update the mask_type attribute to include the magic string for the gridded data used for data masking.

* Per #2966, adjust the logic slightly to revert to existing behavior where we only write the timing information of the input data to the gen_vx_mask output when no threshold was applied. This should reduce the number of diffs flagged by PR #3008

* Per #2966, update details about the -union, -intersection, and -symdiff options in the usage statement and documentation as recommended by @CPKalb.

---------

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.1.0 milestone Nov 23, 2024
@JohnHalleyGotway JohnHalleyGotway merged commit c813e8e into develop-ref Nov 23, 2024
1 check passed
@JohnHalleyGotway JohnHalleyGotway deleted the update_develop_be5c6b17 branch November 23, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

10 participants