Bugfix 2383 aeronetv3 (main_v11.0) #2394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
jprestop
reviewed
Jan 10, 2023
There was a problem hiding this comment.
I tested on the files obtained in the following way:
wget --no-check-certificate -q -O 20221204.lev15 "https://aeronet.gsfc.nasa.gov/cgi-bin/print_web_data_v3?year=2022&month=12&day=04&year2=2022&month2=12&day2=04&AOD15=1&AVG=10&if_no_html=1"
wget --no-check-certificate -q -O GSFC_20221204.lev15 "https://aeronet.gsfc.nasa.gov/cgi-bin/print_web_data_v3?site=GSFC&year=2022&month=12&day=04&year2=2022&month2=12&day2=04&AOD15=1&AVG=10&if_no_html=1"
The files produced the expected results. I approve this request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Problem 1. The python utility script, print_pointnc2ascii.py, fails if the MET point observation file contains NaN.
Problem 2. The computed AOD 550, NaN, should not be saved which happens when AOD 440 is -999.00 or AOD 650.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Problem 1: the python script
Problem 2: having NaN at ascii2nc output:
Before:
After:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
[x ] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes