Expected Differences

MET #2924 is a large development task that has been split into 2 pull requests. PR #2939 contained this first set of changes and this PR contains the second set of changes.

This second pull request includes changes to 25 files, outlined below:

• [2] Header data files (met_header_columns_V12.0.txt and met_12.0.hdr) renames existing and adds new columns to the MPR and ORANK line types.

• [3] stat_column_defs.h, stat_columns.cc, and pair_data_point.cc add/modify MPR/ORANK column names.

• [2] gsi_tools are updated to handle the MPR and ORANK line type changes.

• [3] docs/Users_Guide files update the documentation and make more consistent use of the .. note:: option (unrelated to this issue). config_options.rst adds the example config setting, as requested.

• [7] Unit test files. unit_climatology_mixed.xml defines 1 new calls to Grid-Stat with mixed fcst/obs climo data. Column names updated in unit_climatology_1.5deg.xml. 1 new and 2 updated config files in internal/test_unit/config. unit_test.sh and testing.yml now call the new xml file.

• [1] Minor changes to comments in threshold.cc

• [7] read_climo.h/.cc are updated to print more descriptive log messages about the data being read, and ensemble_stat.cc, grid_stat.cc, point_stat.cc, series_analysis.cc, and gen_ens_prod.cc are updated to pass those description strings.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes]
  
  If yes, please describe:
  

  • In MPR line type:
    • Renames columns CLIMO_MEAN, CLIMO_STDEV, and CLIMO_CDF as OBS_CLIMO_MEAN, OBS_CLIMO_STDEV, and OBS_CLIMO_CDF, respectively.
    • Adds new columns FCST_CLIMO_MEAN and FCST_CLIMO_STDEV.
  • In ORANK line type:
    • Renames columns CLIMO_MEAN, CLIMO_STDEV as OBS_CLIMO_MEAN, OBS_CLIMO_STDEV, respectively.
    • Adds new columns FCST_CLIMO_MEAN and FCST_CLIMO_STDEV.
  • Makes similar name changes in gridded NetCDF output files from Grid-Stat.

Pull Request Testing

• Describe testing already performed for these changes:
  
  Tested by adding new unit test. After GHA testing workflow is done, I'll add a description of the diffs ehre.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Review code changes and documentation updates. Recommend testing with data provided by NOAA.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Please review the updates docs for this PR: https://met--2942.org.readthedocs.build/en/2942/

• Do these changes include sufficient testing updates? [Yes]
  Adds 1 new unit test in a new unit_climatology_mixed.xml file.

• Will this PR result in changes to the MET test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  

• All the MPR and ORANK output is modified.

• Expect updated NetCDF variable names in the Grid-Stat matched pairs files.

• Adds new output for new unit test.

• Will this PR result in changes to existing METplus Use Cases? [Yes]
  
  If yes, create a new Update Truth METplus issue to describe them.

• Changes to the MPR and ORANK line types.

• See Update Truth: For dtcenter/MET#2942 METplus#2656

• Do these changes introduce new SonarQube findings? [Yes]
  
  If yes, please describe:

• In this SonarQube scan flags 1 code smell about a function with > 7 args. This is an existing smell and we actually have many instances of it. We have not decided to tackle this one yet.

• It also flags 10% duplication, and we've also decided not to attack this yet either.

• Please complete this pull request review by [Monday 8/5/24].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.