Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 2, 2024

PR #2803 intentionally deletes PB2NC output file created using Python embedding:

ERROR: folder /data/output/met_test_output missing 1 files
    python/pb2nc_TMP.nc 

PR #2806 modifies the DESC column of a Stat-Analysis output file:

COMPARING stat_analysis_ps/POINT_STAT_FILTER_OBS_SID.stat
file1: /data/output/met_test_truth/stat_analysis_ps/POINT_STAT_FILTER_OBS_SID.stat
file2: /data/output/met_test_output/stat_analysis_ps/POINT_STAT_FILTER_OBS_SID.stat
ERROR: header information mismatch in column DESC

SUMMARY for non-bootstrap numerical values
# comparisons: 0
# differences: 0

ERROR: failed tests for MPR#37: hdr

Updating develop-ref to move past these expected differences.

Created by @JohnHalleyGotway

MET Tools Test Account and others added 30 commits November 19, 2023 19:42
…ated when running bootstrap inside the dtcenter/met-base:v3.1 Docker image. Updates autoconf 2.69 output to 2.71.
Fixed incorrect path to obs error table
…g the default version which no longer exists in /usr/local
… ncdiff. I did test running comp_dir.sh with this change and confirmed that it now runs to completion.
…ent variable SONAR_TOKEN_VALUE and SONAR_SERVER_URL
…trings, SONAR_TOKEN_VALUE and SONAR_SERVER_URL
* Per #2776, delete stale prob_pair_info.h/.cc, wwmca_utils.h/.cc, and rmw_analysis_utils.h/.cc files that were not being compiled by their Makefiles.

* Per #2776, update Makefile to compile the test_read_rmw utility.

* Per #2776, add Makefile for the vx_python3_utils test utility directory.

* add rpath for atlas and eckit lib dirs so dynamic libraries can be found when running on seneca

* only set -L and -I arguments for atlas and eckit if the appropriate environment variable is set -- this matches how it is handled for other external library dependencies

* Per #2776, just whitespace and capitalization

---------

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
* Per #2782, port over fixes from the bugfix_2782_main_v11.1_MASSDEN branch over to the bugfix branch for develop. Will also add new GRIB2 filtering options in this branch.

* Per #2782, add support for 4 new GRIB2 filtering options for GRIB2_aerosol_type, GRIB2_aerosol_interval_type, GRIB2_aerosol_size_lower, and GRIB2_aerosol_size_upper. These are useful in filtering the MASSDEN records in the RRFS smoke output files.

* Per #2782, fix aerosol_size_lower() and aersol_size_upper() inline definitions.

* Per #2782, add a unit test for GRIB2 table 4.48.

* Per #2782, switch from strict equality to using the is_eq() function when checking the GRIB2_aerosol_size_lower and upper values since they're doubles and not ints.
* Add support for ISMN soil moisture data

* Per #2701, update ascii2nc.cc with the ismn file option.

* Per #2701, update ascii2nc docs

* Per #2701, store the depth for precip as 0.

* Per #2701, parse the ISMN observation value from the correct column.

* Per #2701, every time I run ascii2nc to I see a log message for 'DEBUG 1: Number of NDBC skipped files due to no lookup 0'. This is printed by the NdbcHandler destructor. Update the logic to only print a debug level 3 log message when the number of missing locations is greater than 0, 'DEBUG 3: Skipped 5 NDBC files whose locations are not defined in 'MET_BASE/table_files/ndbc_stations.xml'. Set the MET_NDBC_STATIONS environment variable to override this file.'

* Per #2701, as instructed by @anewman89, store the average of the depth values rather than the maximum value.

* Per #2701, add a test of processing the ISMN data through ascii2nc.

* Per #2701, fix parsing of year and month to subtract 1900 and 1, respectively.

* Per #2701, set use_var_id to true for ISMN inputs

* Per #2701, even though we're mapping obs data to GRIB code names and units, we want to encode them with use_var_id = true and so we need to keep track of those var_id values.

* Per #2701, fix typo in the name of the ascii2nc netcdf output file.

---------

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
hsoh-u and others added 25 commits January 29, 2024 11:14
* Per #2801, add new time_offset_warning config option.

* Per #2810, update MetConfig class to parse and check the time_offset_warning config option.

* Per #2801, update Grid-Stat, MODE, PCP-Combine, Series-Analysis, Wavelet-Stat, and the WWMCA tool to call MetConfig::time_offset_warning() to decide whether to print a Warning or Debug(3) log message about initialization or valid time differences.

* Per #2801, no change to content. Just removing unneeded whitespace.

* Per #2801, remove extra empty line foromw m warning message.

* Per #2801, remove extra empty line from MODE warning messages.

---------

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
…replaced them to tmp_point_var_name and tmp_point_data
…ar_name to tmp_py_base_name, tmp_file_var_name, & tmp_point_var_name
* Working mvmode with percentile thresholds and grid_type fixes, plus more unit tests

* separated multivar and traditional mode frontend classes to simplify the mode executive class design

* documentation changes to go with changes to percentiles and data_type

* Cleanup and bugfix to doc

* Bug fix to doc

* Another bugfix attempt

* synching up development.seneca with what is in the develop branch

* added clone() method to all the vx_data2d var_info classes

* Fix multivar_name/level definitions in UG

* bug fix regarding accessing the config to create a verification grid

* Update docs/Users_Guide/mode.rst

* Update docs/Users_Guide/mode.rst

* Per #2745, commit changes to Makefile.am/.in files after running bootstrap on this feature branch on seneca.

* Per #2745, no real code changes. Just whitespace.

---------

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Tracy Hertneky <hertneky@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
…t would have been a duplicate after adding MET_PYTHON_EXE
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
* Per #2805, update STATAnalysisJob::dump_stat_line() to take an optional argument to indicate whether the set_hdr options should be applied. Update Stat-Analysis to only call dump_stat_line() with set_hdr for filter jobs.

* Per #2805, update User's Guide with -set_hdr info.

* Per #2805, the -set_hdr option doesn't apply to tc_stat

* Per #2805, modify one Stat-Analysis filter job to demonstrate that the -set_hdr job command option is now applied to the -dump_row output.

* Per #2805, enhance the R differencing logic to handle NA strings in the header columns. Previously, differences that include the NA string were ignored. This enhances the compareStatLty() function to handle NA strings properly.

* Per #2805, no real code change. Just whitespace.

---------

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Feb 2, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Update develop-ref after #2806 and #2807 Update develop-ref after #2803 and #2806 Feb 2, 2024
@JohnHalleyGotway JohnHalleyGotway merged commit b2ea670 into develop-ref Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

8 participants