Update develop-ref after #2728, #2723, #2736 #2747

github-actions · 2023-11-17T23:01:03Z

Updating based on changes from 3 recent PR's:

PR Feature #2550 compute_diagnostics #2728 for issue Enhance TC-Diag to actually compute and write diagnostics #2550 adds new TC-Diag output files.

ERROR: folder /data/output/met_test_truth missing 2 files
    tc_diag/sal092022_gfso_doper_2022092400_cyl_grid_parent.nc 
    tc_diag/sal092022_gfso_doper_2022092400_diag.nc 
ERROR: folder /data/output/met_test_output missing 1 files
    tc_diag/tc_diag_AL092022_GFSO_2022092400_cyl_grid_parent.nc

PR Feature 2231 unstructured grid #2723 for issue Add support for NetCDF files following the UGRID convention #2231 adds 20 new Point-Stat and Grid-Stat UGRID output files:

ERROR: folder /data/output/met_test_truth missing 20 files
    grid_stat_ugrid/grid_stat_UGRID_MPAS_DIAG_000000L_20120409_120000V.stat 
    grid_stat_ugrid/grid_stat_UGRID_MPAS_DIAG_000000L_20120409_120000V_pairs.nc 
    grid_stat_ugrid/grid_stat_UGRID_MPAS_OUT_TO_GRID_000000L_20120409_120000V.stat 
    grid_stat_ugrid/grid_stat_UGRID_MPAS_OUT_TO_GRID_000000L_20120409_120000V_pairs.nc 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V.stat 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_cnt.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_ctc.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_cts.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_eclv.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_fho.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_mpr.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_DIAG_TEMP_000000L_20120409_120000V_vcnt.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V.stat 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_cnt.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_ctc.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_cts.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_eclv.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_fho.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_mpr.txt 
    point_stat_ugrid/point_stat_UGRID_MPAS_OUT_TEMP_000000L_20120409_120000V_vcnt.txt

PR Feature #2699 consensus_config #2736 for issue Refine TC-Pairs consensus diagnostics configuration options #2699 modifies the contents of an existing TC-Pairs output file.

/data/output/met_test_output/tc_pairs/al092022_20220926_DIAGNOSTICS_CONSENSUS.tcst

Updating develop-ref to get past these diffs.

Created by @JohnHalleyGotway

…T into feature_2285_read_point_data

…ocks that might be nice to link to since with a caption, the code block has a copyable link to share.

…_tools

…T into feature_2285_read_point_data

…_tools

…ing from python script.

…line only and no config file is involved.

Co-authored-by: jprestop <jpresto@ucar.edu>

…T into feature_2285_read_point_data

…s_ncutil Feature 2474 sonarqube findings ncutil

Fixes typo in Appendix F.

…T into feature_2285_read_point_data

* mods to use the multivar mode default config (when in multivar mode), and to check for problematic merge config settings * added more meaningful error and debug messages * Modified documentation to better describe multivariate mode including new default values * Bug fix for unit test * cleanup and fix a bug in which the default output path was not set in multivar mode * Changed multivar_name value to 'Super' in MODEMultivarConfig_default

Write the output from bootstrap to a log file to determine the autoconf version being run.

* mods to use the multivar mode default config (when in multivar mode), and to check for problematic merge config settings * added more meaningful error and debug messages * Modified documentation to better describe multivariate mode including new default values * Bug fix for unit test * cleanup and fix a bug in which the default output path was not set in multivar mode * Changed multivar_name value to 'Super' in MODEMultivarConfig_default * Update multivar_name value and description in mode.rst --------- Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

* updating headers for consistency * fixing headers adding captialization * capitalizing titles * adding capitalization to headers * switching headers back * updating headers * updating headers * capitalizing titles * capitalizing titles * Update docs/Contributors_Guide/dev_details/index.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/index.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/index.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Contributors_Guide/dev_details/tmp_file_use.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/appendixC.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update docs/Users_Guide/masking.rst Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>

Feature 2673 sonarqube

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: root <root@83062d57c5dd>

Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

JohnHalleyGotway · 2023-11-17T23:44:42Z

I note that the differences flagged in this GHA run are all consistent with the expected differences. Will merge this PR and proceed with updating the contents of develop-ref.

Howard Soh and others added 30 commits April 14, 2023 11:11

#2474 Removed the convertion option

d4c8844

Merge branch 'feature_2285_read_point_data' of github.com:dtcenter/ME…

f921a9a

…T into feature_2285_read_point_data

Cleans up code-block formatting and adds captions to relevant code bl…

9b1134c

…ocks that might be nice to link to since with a caption, the code block has a copyable link to share.

Adds example of dual Python embedding for PointStat.

7d70498

Updates to the MPR section.

abad322

Removes Python embedding example and moves to Appendix F.

38a7478

Corrects RST error.

aadfb92

RST link errors.

e179642

@2474 Changed long pointer to LongArray

a766cab

#2474 Use LongArray for NetCDF API

b197624

#2474 Formating (intend), Moved convert_point_data to under met_point…

47af55d

…_tools

Merge branch 'feature_2285_read_point_data' of github.com:dtcenter/ME…

aa395e5

…T into feature_2285_read_point_data

#2474 Formating (intend), Moved convert_point_data to under met_point…

c893ed0

…_tools

#2474 Changed 0 to nullptr

422baa3

#2474 Assign FO_Node instead of calling memcpy

af6712c

#2285 Check and give wwarning if met_point_data or point_data is miss…

08aeeec

…ing from python script.

A few grammar/typo fixes.

465be3e

Adds error messages for Python embedding if MET is not Python enabled.

d28d550

Removes examples for MPR/StatAnalysis since it's really just command …

8b5989d

…line only and no config file is involved.

Adds brief blurb about the MET Python package.

716f922

Corrects path in MPR example and removes MET_BASE.

5244b66

Update docs/Users_Guide/appendixF.rst

d199e17

Co-authored-by: jprestop <jpresto@ucar.edu>

Update docs/Users_Guide/appendixF.rst

fb43a77

Co-authored-by: jprestop <jpresto@ucar.edu>

Adds missing scripts directory for two commands.

9890fd8

Merge branch 'feature_2285_read_point_data' of github.com:dtcenter/ME…

2334d1a

…T into feature_2285_read_point_data

Merge pull request #2512 from dtcenter/feature_2474_sonarqube_finding…

c3ab2c2

…s_ncutil Feature 2474 sonarqube findings ncutil

Update appendixF.rst

9364ae1

Fixes typo in Appendix F.

Updates the MET_PYTHON_INPUT_ARG section of the documentation.

ccd2612

Merge branch 'feature_2285_read_point_data' of github.com:dtcenter/ME…

7eef4df

…T into feature_2285_read_point_data

Breaks long command into 2 lines for readability.

a849167

davidalbo and others added 26 commits October 26, 2023 15:06

Update build_met_docker.sh

3ea3a8a

Write the output from bootstrap to a log file to determine the autoconf version being run.

Feature #2724 mode_openmp (#2726)

46cf0db

#2673 Initialize i

67e88c0

#2673 Check the return value from mtd_three_to_one

ca96237

#2673 Initialize conv_data

8c6c14e

2673 Initialize pcp_recs and pcp_files

98f01ba

#2673 Adjust count by the density vector size

258b997

#2673 Updated return statement for SonarQube

2a8d27f

#2673 Initialize packed_data

cf6e929

#2673 Updated return statement for SonarQube

f80b71f

Merge pull request #2731 from dtcenter/feature_2673_sonarqube

d6fe7e7

Feature 2673 sonarqube

Bugfix #2730 develop SI_BCU (#2732)

6077175

Merge remote-tracking branch 'origin/develop-ref' into develop

501bdeb

Feature #2611 oneapi met-basev3.1 (#2737)

b17ff51

Add user execute permissions to compile script - develop (#2739)

62c3dea

Feature #2699 consensus_config (#2736)

bbe91b4

Feature 2673 sonarqube beta2 (#2743)

3dab2dd

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>

Feature 2231 unstructured grid (#2723)

9c33f83

Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: root <root@83062d57c5dd>

Feature 2706 mvmode obs fcst input size (#2742)

8a55188

Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@ucar.edu>

Feature #2471 v12.0.0_beta2 (#2744)

1e52421

Feature #2550 compute_diagnostics (#2728)

36868c1

Hotfix to develop to fix a typo in mode_conf_info.h

008ad83

Merge remote-tracking branch 'origin/develop-ref' into develop

41e2153

JohnHalleyGotway changed the title ~~Update develop-ref after #2728, #2723, #2742, #2736~~ Update develop-ref after #2728, #2723, #2736 Nov 17, 2023

JohnHalleyGotway added this to the MET 12.0.0 milestone Nov 17, 2023

JohnHalleyGotway merged commit f39afeb into develop-ref Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update develop-ref after #2728, #2723, #2736 #2747

Update develop-ref after #2728, #2723, #2736 #2747

Uh oh!

github-actions bot commented Nov 17, 2023 •

edited by JohnHalleyGotway

Loading

Uh oh!

JohnHalleyGotway commented Nov 17, 2023

Uh oh!

Uh oh!

Update develop-ref after #2728, #2723, #2736 #2747

Update develop-ref after #2728, #2723, #2736 #2747

Uh oh!

Conversation

github-actions bot commented Nov 17, 2023 • edited by JohnHalleyGotway Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JohnHalleyGotway commented Nov 17, 2023

Uh oh!

Uh oh!

github-actions bot commented Nov 17, 2023 •

edited by JohnHalleyGotway

Loading