Expected Differences

The missing PBL values are expected. John HG ran the Docker manually and got 392 obs. He will update True output set.

pb2nc.cc: There was a minor bug that the first pressure level is not correct. It does not affect the computed PBL value. map<float, float*> pqtzuv_map_merged is changed to vector<float*> pqtzuv_merged_array to fix the invalid pressure at the first record. The pb2nc output should not be changed with this fix.

The other changes are for the SonarQube findings.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

/d1/personal/hsoh/git/pull_request/MET_bugfix_2687_hpbl/bin/pb2nc /d1/projects/MET/MET_test_data/unit_test/obs_data/prepbufr/nam.20210311.t00z.prepbufr.tm00 ./ndas.20120409.t12z.prepbufr.tm00.new.nc /d1/personal/hsoh/git/pull_request/MET_bugfix_2687_hpbl/internal/test_unit/config/PB2NCConfig_pbl -v 8 >& log_new_pbl.log

/d1/projects/MET/MET_regression/develop/NB20231019/MET-develop/bin/pb2nc /d1/projects/MET/MET_test_data/unit_test/obs_data/prepbufr/nam.20210311.t00z.prepbufr.tm00  ./ndas.20120409.t12z.prepbufr.tm00.old.nc /d1/personal/hsoh/git/pull_request/MET_bugfix_2687_hpbl/internal/test_unit/config/PB2NCConfig_pbl -v 8 >& log_old_pbl.log

grep "DEBUG 8: compute_pbl()   0"  log_new_pbl.log | less
grep "DEBUG 8: compute_pbl()   0"  log_old_pbl.log | less

Make sure the pressure value for the first record is not 0 and not too big.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  N/A

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

• Do these changes include sufficient testing updates? [No]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Monday 10/23/24].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.