Skip to content

Bugfix 2666 point2grid usage #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2023
Merged

Bugfix 2666 point2grid usage #2700

merged 3 commits into from
Oct 4, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Oct 3, 2023

Expected Differences

The usage message of point2grid

where   "input_filename" is the gridded data file to be read (required).
==>
where   "input_filename" is the input NetCDF point observation file to be read (required).

Two additional changes for ReadTheDocs (happedn at this branch)

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Run point2grid and check the description of input_filename
/d1/personal/hsoh/git/pull_request/MET_bugfix_2666_point2grid_usage/bin/point2grid

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Oct. 06. 2023].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 12.0.0 milestone Oct 3, 2023
@hsoh-u hsoh-u requested a review from jprestop October 3, 2023 19:53
@hsoh-u hsoh-u linked an issue Oct 3, 2023 that may be closed by this pull request
Bugfix: Correct the usage statement for Point2Grid #2666
Closed
23 tasks
jprestop
jprestop approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran /d1/personal/hsoh/git/pull_request/MET_bugfix_2666_point2grid_usage/bin/point2grid and checked the usage statement and ensured all tests passed. Please note that the one failure is unrelated to this PR. Also included in this PR are some edits I made to fix the ReadTheDocs errors. I approve this request.

@hsoh-u hsoh-u merged commit d4c369e into develop Oct 4, 2023
@hsoh-u hsoh-u deleted the bugfix_2666_point2grid_usage branch October 4, 2023 16:16
@jprestop
Copy link
Collaborator

jprestop commented Oct 4, 2023

Hi @hsoh-u. Unfortunately, I'm a little late in noticing that this is a bugfix. Looking at the issue, I see that this bugfix was only applied to the develop branch. However, I see that the issue #2666 only has the 12.0.0-beta2 Project assigned. Should there be a corresponding bugfix for MET-11.1.0? Or was it intended for this only to go into develop? Thanks!

@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Oct 4, 2023

I did not make a bugfix branch for MET-11.1.0 because this is a minor issue. I will make it for MET-11.1.0.

@jprestop
Copy link
Collaborator

jprestop commented Oct 4, 2023

Thanks @hsoh-u. I went ahead and added "Coordinated METplus-5.1 Support" to the issue for clarity and as a reminder it would be done for MET-11.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprestop jprestop jprestop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
MET-12.0.0 Development
Status: 🏁 Done
Milestone
MET-12.0.0
Development

Successfully merging this pull request may close these issues.

Bugfix: Correct the usage statement for Point2Grid
3 participants
@hsoh-u @jprestop @JohnHalleyGotway