Skip to content

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Jul 12, 2023

Expected Differences

  • Support swap_to_north option for rotated lat/lon projection

  • Allow extra space character around "since" for the time reference string, for example "hours since 2022-02-17 00:00:00" (two spaces after since)

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

/d1/personal/hsoh/git/pull_request/MET_bugfix_2578_rotated_latlon_main_v11.0/bin/plot_data_plane /d1/personal/hsoh/data/MET-2578/test_lfric_lam.nc rotated_latlon.ps 'name="t1p5m"; level="(*,*)";' -v 7
display rotated_latlon.ps

log messages before

DEBUG 4: NcCfFile::open() -> parsing units for the forecast_reference_time variable "hours since  2022-02-17 00:00:00"
WARNING:
WARNING: parse_cf_time_string() -> unexpected NetCDF CF convention time unit "hours since  2022-02-17 00:00:00"
WARNING:

log messages after

DEBUG 4: parse_cf_time_string() -> parsed NetCDF CF convention time unit string "hours since  2022-02-17 00:00:00"
DEBUG 4:                 as a reference time of 20220217_000000 and 3600 second(s) per time step.
...
DEBUG 2: NcCfFile::getData(NcVar *, const LongArray &, DataPlane &) const -> data was flipped to north.
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u requested a review from jprestop July 12, 2023 18:20
@hsoh-u hsoh-u linked an issue Jul 12, 2023 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsoh-u I have reviewed the code changes and the output from your before and after runs. All of the tests passed. I approve this request.

@hsoh-u hsoh-u merged commit f0baf7f into main_v11.0 Jul 12, 2023
@hsoh-u hsoh-u deleted the bugfix_2578_rotated_latlon_main_v11.0 branch November 16, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix reading of upside-down CF-compliant NetCDF Rotated Lat/Lon data
2 participants