Skip to content

Conversation

hertneky
Copy link
Contributor

@hertneky hertneky commented Jul 5, 2023

Update UPP website link in 2 places from DTC to EPIC owned website.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the files changed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230710].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Update UPP website link in 2 places from DTC to EPIC owned website.
@jprestop jprestop self-requested a review July 5, 2023 19:42
@jprestop jprestop added this to the MET 11.1.0 milestone Jul 5, 2023
@jprestop jprestop changed the title Update installation.rst Modify installation.rst file to update UPP website link Jul 5, 2023
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and verified that the new links work. All tests have passed. Thank you @hertneky for catching this and for making these changes! I approve this request.

@jprestop jprestop merged commit 8708b43 into main_v11.1 Jul 5, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the hertneky-patch-1 branch December 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants