Skip to content

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Jun 9, 2023

My original PR (#2554) was submitted to the wrong target branch (main_v11.0 instead of develop). Closing that PR and opening this one to propose changes to the correct branch.

Incorporating minor changes to the message_type_map ASCII2NC settings for Little R.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None, just based this changes on functionality reported by @CPKalb.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    @CPKalb please review and confirm these changes are what you need.
    Also, confirm that all the unit tests passed with no differences being flagged.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    Updated setting in user's guide.

  • Do these changes include sufficient testing updates? [Yes]
    No new unit tests are needed.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Thursday 6/8/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway
Copy link
Collaborator Author

Proceeding with this PR without an approving review. The change is minor and is exactly what was requested in the issue.

@JohnHalleyGotway JohnHalleyGotway merged commit 0195876 into develop Jun 9, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2487_littleR branch June 9, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update the default ASCII2NC message_type_map configuration option for Little R input data
1 participant