Skip to content

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented May 19, 2023

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    I tested the script on WCOSS2 Acorn, which uses modules to load both the compiler and the python versions. I test the new functionality for both and got successful runs. I tested the script on Cheyenne, which uses modules to load the compiler, but not Python, and got successful runs. I tested the new compiler specification functionality on seneca (with a subset of the script since that compiler doesn't exist on seneca and neither does the module load functionality) using gnu8 for the COMPILER_NAME, as described in this comment from Discussion 2485.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the code changes, if desired. I believe the script has been well tested. Bugs were found and fixed in testing.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [See below]
    I have updated the documentation within the script. An overhaul for more and better documentation is needed in the User's Guide and/or the website, but there will be an issue created by @j-opatz with the results from the focus group. I am waiting until that issue is created to revamp the script documentation in the User's Guide and/or the website.

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230524].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

Julie, sorry for the delay. I forgot about this one. I see that all GHA tests have passed but I performed no additional testing. I did skim through the code changes looking for typos but didn't find anything. Thanks for getting these changes in!

@jprestop jprestop merged commit 1b4704a into develop May 24, 2023
@jprestop jprestop deleted the feature_2540_2485_compilation branch May 24, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
2 participants