Skip to content

Bugfix #2525 nhdr 1 off #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2023
Merged

Bugfix #2525 nhdr 1 off #2529

merged 3 commits into from
Apr 28, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Apr 27, 2023 •
edited
Loading

Expected Differences

  • The hid is the index for header. The header count is hid plus 1.

  • Use -9999. as the missing value for the masked value (1.e20)

  • Removed the log message

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:
/d1/personal/hsoh/git/pull_request/MET_bugfix_2525_nhdr_1_off/bin/plot_point_obs 'PYTHON_NUMPY=/d1/personal/biswas/METplus_TCI/parm/use_cases/model_applications/land_surface/PointStat_fcstCESM_obsFLUXNET2015_TCI/fluxnet2015_tci.py /d1/personal/biswas/feature_2011_TCI_from_CESM_FLUXNET2015/model_applications/land_surface/F2015_LoCo_AllChains_F2015.nc4 JJA' python-point-data.ps -v 3

before

DEBUG 2: Processing 177 observations at 176 locations.
DEBUG 1: Creating postscript file: python-point-data.ps
DEBUG 3: For point data group 1, plotting 177 locations for 177 observations.
DEBUG 2: Finished plotting 177 locations for python-point-data.ps.

after

DEBUG 2: Processing 177 observations at 177 locations.
DEBUG 1: Creating postscript file: python-point-data.ps
DEBUG 3: For point data group 1, plotting 177 locations for 177 observations.
DEBUG 2: Finished plotting 177 locations for python-point-data.ps.
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

METplus use case

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u requested a review from DanielAdriaansen April 27, 2023 21:12
@hsoh-u hsoh-u linked an issue Apr 27, 2023 that may be closed by this pull request
Bugfix: Fix the fill value setting used in the write_tmp_dataplane internal Python embedding script #2525
Closed
22 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title Bugfix 2525 nhdr 1 off Bugfix #2525 nhdr 1 off Apr 28, 2023
DanielAdriaansen
DanielAdriaansen approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@DanielAdriaansen DanielAdriaansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. Thanks @hsoh-u

@hsoh-u hsoh-u merged commit 38e68e7 into develop Apr 28, 2023
@hsoh-u hsoh-u added this to the MET 11.0.2 (bugfix) milestone Apr 28, 2023
@hsoh-u hsoh-u deleted the bugfix_2525_nhdr_1_off branch April 28, 2023 15:12
This was referenced Apr 28, 2023
Closed
Closed
georgemccabe added a commit to dtcenter/METplus that referenced this pull request Apr 28, 2023
@github-actions @jprestop
@JohnHalleyGotway @cristianastan2 @bikegeek @lisagoodrich @georgemccabe @hankenstein2 @DanielAdriaansen @j-opatz @willmayfield @metplus-bot @hertneky
Update develop-ref after dtcenter/MET#2529 and #2148 (#2153)
4e79162 
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: cristianastan2 <cstan@gmu.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: bikegeek <minnawin@ucar.edu>
Co-authored-by: Lisa Goodrich <lisag@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: Tracy Hertneky <hertneky@seneca.rap.ucar.edu>
Co-authored-by: Giovanni Rosa <giovanni.rosa@unimol.it>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: j-opatz <jopatz@ucar.edu>
Co-authored-by: Will Mayfield <59745143+willmayfield@users.noreply.github.com>
Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com>
Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com>
Co-authored-by: Giovanni Rosa <g.rosa1@studenti.unimol.it>
fixing errors #650
fixing errors take 2 #650
fixing errors take 3 #650
fixing errors take 4 #650
fixing errors take 5 #650
fixing question order #650
fix #1706 fix PhaseDiagram use case to avoid writing into INPUT_BASE (#1708)
fix #1713 develop METPLOTPY_BASE (#1715)
fix #1691 remove whitespace from output file paths (#1721)
fix Contributor's Guide GitHub Workflow page (#1774)
fix release (#1790)
fix GitHub Actions warnings (#1864)
fix #1884 develop PCPCombine {custom} in subtract method (#1887)
fix #1939 develop - failure reading obs when zipped file also exists (#1941)
Closes #1986
fix develop Fix broken documentation links (#2004)
fix #2026 develop StatAnalysis looping (#2028)
fix priority of obs_window config variables so that wrapper-specific version is preferred over generic OBS_WINDOW_BEGIN/END (#2062)
fix #2070 var list numeric order (#2072)
fix #2087 develop docs_pdf (#2091)
fix #2096/#2098 develop - fix skip if output exists and do not error if no commands were run (#2099)
Fix for Dockerfile smell DL4000 (#2112)
fix #2082 develop regrid.convert/censor_thresh/censor_val (#2140)
fix #2082 main_v5.0 regrid.convert/censor_thresh/censor_val (#2101)
fix #2137 develop PointStat -obs_valid_beg/end (#2141)
@DanielAdriaansen DanielAdriaansen mentioned this pull request Dec 4, 2023
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielAdriaansen DanielAdriaansen DanielAdriaansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
MET-11.1.0 Development
Status: ✅ Done
Milestone
MET-11.1.0
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix the fill value setting used in the write_tmp_dataplane internal Python embedding script
3 participants
@hsoh-u @DanielAdriaansen @JohnHalleyGotway