Skip to content

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

This PR explains the differences flagged by the nightly build in seneca:/d1/projects/MET/MET_regression/develop/NB20230331.

PR #2495 for issue #2493 modifies the contents of one existing aeronet output file:

COMPARING aeronet/20221202.v3.lev15.nc
file1: MET-develop-ref/test_output/aeronet/20221202.v3.lev15.nc
file2: MET-develop/test_output/aeronet/20221202.v3.lev15.nc
ERROR: found   104 differences in var hdr_elv                                - max abs: 769 
ERROR: found   104 differences in var hdr_lat                                - max abs: 15.5005 
ERROR: found   104 differences in var hdr_lon                                - max abs: 88.0175 

Updating develop-ref to get past these expected differences.

jprestop and others added 30 commits October 4, 2022 11:22
* Per #2227 changes in this commit resolve all errors from removing 'using namespace std' from all header files in the src/basic directory

* Attempt to resolve errors in GitHub actions from removing 'using namepsace std' from all src/basic/ libraries, plus removal from src/libcode/vx_gnomon/gnomon.h and src/libcode/vx_nc_util/nc_utils.h

* Attempt to fix GHA errors with compilation after removal of 'using namespace std'; locally compiles fine

* Per #2227, attempting to fix GHA compilation; Compiltion on seneca works fine

* Per #2227, attempt to resolve GHA compilation issues; seneca compilation works fine

* Per #2227, attempt to resolve GHA compilation issues; seneca compilation works fine

* Per #2227, removing namespace from vx_series_data library

* Per #2227, removing namespace std from vx_shapedata library

* Per #2227, removing namespace std from vx_data2d_grib2 and vx_data2d_grib libraries

* Per #2227, removing namespace std from vx_statistics library

* Per #2227, removing namespace std from src/tools/tc_utils

* Per #2227, removed namespace std from /src/tools/core header files

* Per #2227, clean up and continued work

* Per #2227, changes to remove namespace std and netCDF from header files

* Per #2227, resolve errors in GitHub Actions build

* Per #2227, resolve new errors in GitHub Actions build

* Per #2227, resolve new errors in GitHub Actions build

* Per #2227, resolve new errors in GitHub Actions build

* Per #2227, realign variables

* Per #2227, updating comment

* Per #2227, updating comment

* Per #2227, realign variables

* Per #2227, realign variables

* Per #2227, realign variables

* Per #2227, updating comment

* Update src/basic/vx_config/config.tab.cc

Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>
Changes for #2297 included a small typo that I'm fixing directly in the develop branch.
A final hotfix to the develop branch to get the build_docker_trigger_metplus.yml workflow working again. I tested on feature_2297_gha branch to confirm that no double-quotes are actually needed.
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Clean up Python Embedding scripts
Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
… line type table for the RMSOA, ANOM_CORR_UNCNTR, and SI statistics.
* Per #2232, add SPREAD_MD to the ECNT line type from Ensemble-Stat and computed for HiRA.

* Per #2332, fix compilation error.

* Per #2332, update date and release notes for met-11.0.0-beta4.

* Per #2332, fix compilation error.
Howard Soh and others added 27 commits February 23, 2023 16:36
Bugfix 2428 python embedding with MET_PYTHON_EXE defined
* testing dropdown menu to see if it works.

* adding sphinx_design to config.py and requirements.txt so that dropdown menus will work.

* testing dropdown menus and fixing to rst formatting

* adding non-child dropdown menus

* First try at child dropdown menus

* Second try at child dropdown menus

* Third try at child dropdown menus

* child dropdown menus
…rance score equation in Appendix C is slightly incorrect. Updating to make it consistent with equation 8 in Gneiting et al 2005.
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
1. Fix typo: MET-11.0.1 upgrade instructions should be MET-11.1.0.
2. Add note to update instructions about setting MET_PYTHON_BIN_EXE.
3. Use code-block formatting in config_options.rst to get rid of unexpected indent warning when building the docs.
MET_PYTHON should be the location containing the bin, include, lib and share directories for Python; Removing "/bin" from MET_PYTHON value
The structural changes in the last official release removed the met subdirectory.
Added python -m pip install -r docs/requirements.txt
…on_elv

#2493 updates lat/lon/elv if SiteName is changed
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Mar 31, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Mar 31, 2023 that may be closed by this pull request
22 tasks
@JohnHalleyGotway JohnHalleyGotway merged commit fef0a54 into develop-ref Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bugfix: AERONET the lat/lon is not changed with different station ID
8 participants