Skip to content

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review minor update to 11.0.1 release notes. Note that I only added 1 from 11.0.1-rc1 to 11.0.1. And note that I did NOT include the issues for actually creating the 11.0.1-rc1 and 11.0.1 releases in the release notes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Tues 2/28/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.1 (bugfix) milestone Feb 28, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Feb 28, 2023 that may be closed by this pull request
20 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the release notes both in the "Files Changed" section and via ReadTheDocs. They look good to me. I approve this PR.

@JohnHalleyGotway JohnHalleyGotway merged commit 11c4d3d into main_v11.0 Feb 28, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2472_v11.0.1 branch February 28, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Create the MET-11.0.1 release
2 participants