Skip to content

Feature #2469 2023_v11.1.0 #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2023
Merged

Feature #2469 2023_v11.1.0 #2471

merged 3 commits into from
Feb 27, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Feb 27, 2023 •
edited
Loading

While there are a massive number of files changed, the actual changes are very minor.

  • Update the copyright date from 2022 to 2023 in the source code.
  • Switch "V11.0.0" to "V11.1.0" in all the config files.
  • Switch the code version in util_constants.h and docs/conf.py to 11.1.0.
  • Add header table files for version 11.1.0 and update Makefile.am to install them.

##Expected Differences ##

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    • Compiled this feature branch and ran all the unit tests in seneca:/d1/projects/MET/MET_pull_requests/met-11.1.0/met-11.1.0-beta1/feature_2469/MET-feature_2469_2023_v11.1.0/internal/test_unit.
    • Copied the v11.1.0 output and renumbered it as v11.0.0 (looking for files ending with .stat, .txt, .tcst, .out, and .dump).
    • Then diffed against the nightly build output.
cd /d1/projects/MET/MET_pull_requests/met-11.1.0/met-11.1.0-beta1/feature_2469/MET-feature_2469_2023_v11.1.0
internal/test_unit/bin/comp_dir.sh test_output_V11.0.0 /d1/projects/MET/MET_regression/develop/NB20230226/MET-develop/test_output >& comp_dir.log

Checking the diffs in comp_dir.log, I see NO DIFFERENCES flagged.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    • Confirm that all GHA tests run without error.
    • The difference comparison step will time out. Since a simple file diff does not suffice with a version diff present, the comparison step will take too long and time out.
    • See the comp_dir.log file referenced above.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Mon 2/27/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Feb 27, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Feb 27, 2023 that may be closed by this pull request
Update the copyright year to 2023 and increase the version number to 11.1.0. #2469
Closed
20 tasks
@JohnHalleyGotway
Per #2469, adding met_header_columns_V11.1.txt to the Makefile so tha…
2b0dc25 
…t its included in the installation directory.
jprestop
jprestop approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the GHA tests and saw that 22 were successful, 2 were cancelled, and 10 were skipped. Since the difference comparison step timed out, as suggested, I reviewed the comp_dir.log file and found no failures or errors. I approve this request.

@JohnHalleyGotway JohnHalleyGotway merged commit b2b92ce into develop Feb 27, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2469_2023_v11.1.0 branch February 27, 2023 19:39
@JohnHalleyGotway JohnHalleyGotway mentioned this pull request Feb 28, 2023
Merged
JohnHalleyGotway added a commit that referenced this pull request Feb 28, 2023
@JohnHalleyGotway @jprestop
@j-opatz @georgemccabe @jvigh @sethlinden @hsoh-u @davidalbo @lisagoodrich @DanielAdriaansen
Update develop-ref after #2471 (#2477)
86040a3 
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: Jonathan Vigh <jvigh@ucar.edu>
Co-authored-by: Seth Linden <linden@ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: davidalbo <dave@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu>
fix 2238 link error (#2255)
fix #2271 develop nbrctc (#2272)
fix #2309 develop tcmpr (#2310)
fix #2306 ascii2nc airnow hourly (#2314)
fix_spread_md (#2335)
fix #2389 develop flowchart (#2392)
Fix Python environment issue (#2407)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406)
fix #2380 develop override (#2382)
fix #2408 develop empty config (#2410)
fix #2390 develop compile zlib (#2404)
fix #2412 develop climo (#2422)
fix #2437 develop convert (#2439)
fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix #2452 develop airnow (#2454)
fix #2449 develop pdf (#2464)
fix #2402 develop sonarqube (#2468)
JohnHalleyGotway added a commit that referenced this pull request Nov 17, 2023
@JohnHalleyGotway
Per #2471, also fix formatting of '2^n x 2^n' LaTeX math equations in…
3b6558b 
… Wavelet-Stat. I removed the 'mathbf' option to eliminate the bolding. I searched through the MET docs and found that about 20% of the time we bold equations and the other 80% of the time we do not.
JohnHalleyGotway added a commit that referenced this pull request Nov 17, 2023
@JohnHalleyGotway
Feature #2471 v12.0.0_beta2 (#2744)
1e52421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprestop jprestop jprestop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
MET-11.1.0 Development
Status: ✅ Done
Milestone
MET-11.1.0
Development

Successfully merging this pull request may close these issues.

Update the copyright year to 2023 and increase the version number to 11.1.0.
2 participants
@JohnHalleyGotway @jprestop