Skip to content

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

PR #2439 for issue #2437 adds 2 new output files from a new unit test and also modifies output from existing unit tests:

ERROR: folder MET-develop-ref/test_output missing 2 files
    climatology_2.5deg/grid_stat_SINGLE_MONTH_CLIMO_2.5DEG_000000L_20201225_120000V_pairs.nc 
    climatology_2.5deg/grid_stat_SINGLE_MONTH_CLIMO_2.5DEG_000000L_20201225_120000V.stat 

The following output files are also modified due to changes in the FCST_UNITS and OBS_UNITS output columns:

file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_1.0DEG_120000L_20120409_120000V_cnt.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_1.0DEG_120000L_20120409_120000V_mpr.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_1.0DEG_120000L_20120409_120000V_sal1l2.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_1.0DEG_120000L_20120409_120000V_sl1l2.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_1.0DEG_120000L_20120409_120000V.stat
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_PREV_MONTH_120000L_20120409_120000V_cnt.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_PREV_MONTH_120000L_20120409_120000V_mpr.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_PREV_MONTH_120000L_20120409_120000V_sal1l2.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_PREV_MONTH_120000L_20120409_120000V_sl1l2.txt
file1: MET-develop-ref/test_output/climatology_1.0deg/point_stat_GFS_CLIMO_PREV_MONTH_120000L_20120409_120000V.stat
file1: MET-develop-ref/test_output/climatology_2.5deg/point_stat_GFS_CLIMO_2.5DEG_120000L_20120409_120000V_cnt.txt
file1: MET-develop-ref/test_output/climatology_2.5deg/point_stat_GFS_CLIMO_2.5DEG_120000L_20120409_120000V_mpr.txt
file1: MET-develop-ref/test_output/climatology_2.5deg/point_stat_GFS_CLIMO_2.5DEG_120000L_20120409_120000V_sal1l2.txt
file1: MET-develop-ref/test_output/climatology_2.5deg/point_stat_GFS_CLIMO_2.5DEG_120000L_20120409_120000V_sl1l2.txt
file1: MET-develop-ref/test_output/climatology_2.5deg/point_stat_GFS_CLIMO_2.5DEG_120000L_20120409_120000V.stat

Updating develop-ref to get past these expected differences.

davidalbo and others added 30 commits August 5, 2022 13:34
Co-authored-by: Dave Albo <dave@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
* Per issue #2055, in read_grib2_record_list() added new PDS numbers 6, 10, 15 (for NBM data). SL

* Per issue #2055: in read_grib2_record_list(), in section that validates PDS number changed, for undefined PDS numbers, changed Error to Warning and continue (instead of exit). SL

* Per issue #2055, created new entries for NBM grib2 data fields. SL

* Per issue #2055. Added more NBM fields based on a 12z, f003 file. SL

* Per issue #2055, after interogating several NBM lead-time files, added TMAX field. SL

* Per issue #2055, added grib2_nbm.txt to the list. SL

* Per #2055, update the grib2_nbm.txt file entries in the table_files Makefiles.

* Per issue #2055, fixed syntax entry for TSTM field. SL

* Per issue #2055, fixed a few more syntax errors for some of the fields. SL

* Per issue #2055, in read_grib2_record_list(), added section to set level values for template number 6 (NBM data). Also added some temporary print statements. SL

* Per issue  #2055, in read_grib2_record_list(), added code to set levels for table number 10 (like 6). SL

* Per #2055, adding support for new GRIB2_perc_val configuration option to filter records based on the forecast percentile value used by GRIB2 product definition templates 6 and 10. Seth, note that I also included the probability filtering logic tweak we discussed, since it was already present in that same file.

* Per issue #2055: in find_record_matches(), in section that resolves Prob fields, changed 'break' to 'continue' for non Probs. SL

* Per issue #2055, in read_grib2_record_list() cleaned up some commented out code. SL

* Per issue #2055, in read_grib2_record_list() cleaned up all print statements. SL

* Per issue #2055, added 5 new unit tests for NBM data. SL

* Update data2d_grib2.cc

* Update data2d_grib2.cc

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
…id_stat, gribtab_dat_to_flat, and gsidens2orank). Also removed commented out code from main.cc.
* Per #2198, adding Seth Linden and Dave Albo to the Author List

* Per #2198, updated Dave Albo to David Albo

* Per #2198, added three new authors based on submitted AMS abstract

* Per #2198, adding .zenodo.json file

* Per #2198, adding orcids for all based on Tatiana's suggestion

* Update .zenodo.json

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update .zenodo.json

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update .zenodo.json

Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: johnhg <johnhg@ucar.edu>
* Per #2196, update for upgrade to Python 3.8.6

* Updated based on new structure of METbaseimage

* Changed MET_BASE_IMAGE references to MET_BASE_TAG; Added information to the README.md file

* Changed MET_BASE_IMAGE references to MET_BASE_TAG; Updated the version from v1.0 to v1.1

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Update internal/scripts/docker/README.md

Based on suggestion from John HG.

Co-authored-by: johnhg <johnhg@ucar.edu>

* Per #2196, updating README.md based on suggestions from John HG

Co-authored-by: johnhg <johnhg@ucar.edu>
* creating chapter files

* putting a space in to work through the git add and commit process.

* Changed formatting of one header

Co-authored-by: Lisa Goodrich <lisag@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
* Per issue #2206, for the ECNT line type, added CRPS_EMP_FAIR. SL

* Per issue #2206, for ECNT line type, added CRPS_EMP_FAIR. SL

* Per issue #2206, for ecnt_columns, added CRPS_EMP_FAIR. SL

* Per issue #2206, in write_ecnt_cols(), added crps_emp_fair. SL

* Per issue #2206, in ECNTInfo, added crps_emp_fair. SL

* Per issue #2206, started stubbing code pieced to calculate crps_emp_fair. SL

* Per issue #2206, added new function mean_abs_diff(). SL

* Per issue #2206, in compute_pair_vals() updated the code to calculate crps_emp and crps_emp_fair. SL

* Per issue #2206, added crps_emp_fair (CRPS_EMP_FAIR) to relevant code pieces. SL

* Per issue #2206, added wording for CRPS_EMP_FAIR, also added it to last column of ECNT line type. SL

* Per issue #2206, added info for CRPS_EMP_FAIR and also added the math equation for this. SL

* Per issue #2206, update the math equation for CRPS_EMP_FAIR. SL

* Per issue #2206, added new function weighted_mean_absolute_diff(). SL

* Per issue #2206, updated the crps_emp_fair calculation to subtract the weighted_mean_abs_diff. SL

* Per issue #2206, in aggr_orank_lines(), updated calculation for crps_emp_fair to use weighted_mean_abs_diff. SL

* Per issue #2206, renamed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, in aggr_orank_lines(), for the crps_emp_fair calculation, changed weighted_mean_abs_diff() to wmean_abs_diff(). SL

* Per issue #2206, updated the math equation for the CRPS_EMP_FAIR calculation. SL

* Per issue #2206, fixed a bug in the wmean_abs_diff() function. SL

* Per issue #2206, added code for crps_emp_fair. SL

* Per issue #2206, in set() function, added checks for crps_emp and crps_emp_fair, for values of 0.0. SL

Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
…r image that it used in the METplus automated tests
Howard Soh and others added 27 commits January 20, 2023 16:08
* Updated module and config files

* Reverting to what was in develop
#2218 Initialize polar stereographics parameters for ellipsoidal earth
…interp dictionary. The parse_conf_interp() function supports the method and width entries being defined as arrays. It automatically processes all possible permutations of their values.
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Refine the regrid dictionary's data conversion and censoring operations and fix climo time matching logic for a single monthly climo file.
9 participants