Skip to content

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Dec 1, 2021

Update main_v10.0-ref to get past diffs from the MET v10.0.1 bugfix release.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Getting past diffs caused by switching VERSION from "V10.0.0" to "V10.0.1".
    The NB failed on 20211202 and all the diffs are in MTD in which version diffs are always flagged.
egrep -i "ERROR:|file1:" test_regression_20211202.log | egrep -B1 ERROR: | grep file1
file1: MET-main_v10.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_2d.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_pair_cluster.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_pair_simple.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_single_cluster.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_BASIC_20100517_010000V_3d_single_simple.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_2d.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_pair_cluster.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_pair_simple.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_single_cluster.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_CONV_TIME_20100517_010000V_3d_single_simple.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_SINGLE_20100517_010000V_2d.txt
file1: MET-main_v10.0-ref/test_output/mtd/mtd_SINGLE_20100517_010000V_3d_single_simple.txt
file1: MET-main_v10.0-ref/test_output/python/mtd_PYTHON_20050807_120000V_2d.txt
file1: MET-main_v10.0-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_pair_cluster.txt
file1: MET-main_v10.0-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_pair_simple.txt
file1: MET-main_v10.0-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_single_cluster.txt
file1: MET-main_v10.0-ref/test_output/python/mtd_PYTHON_20050807_120000V_3d_single_simple.txt

We should obviously enhance the diffing logic to handle this but for now, these diffs are expected.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    Update reference version, as expected.

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway and others added 30 commits May 12, 2021 11:28
…pport extra-tropical cyclone tracks not verified against BEST tracks.
* Updating compile script and associated config files for met-10.0.0

* Removing old config files

* install_met_env.het

* Updated orion file

* Added stampede2 config file

* Adding modulefiles for various machines
* Recommended updates to clarify the use of projects and milestones for bugfixes.

* Making details consistent across all issue templates.
Adding text for GitHub Discussions
…id_latlon_to_laton

Bugfix 1817 met v10.0 point2grid latlon to laton
…ile_list_parsing

Bugfix 1508 met_v10.0 tc_gen file list parsing
* Per #1879, in Ensemble-Stat, only call add_grib_code() when point verification data is provided.

* Per #1879, in the VarInfoGrib::add_grib_code() try doing a table lookup using the user-specified GRIB1 values first and then the default values second. Also, make the error message about no matches much more verbose.
Updated all template to include the addition of new alert labels
…tead of only the filename so that the function can tell whether or not the file exists. (#1953)

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
JohnHalleyGotway and others added 3 commits November 22, 2021 12:39
Merging changes per review approval from @CPKalb, who technically does not have write access for the MET repo.
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0.2 (bugfix) milestone Dec 1, 2021
@JohnHalleyGotway JohnHalleyGotway marked this pull request as ready for review December 2, 2021 15:36
@JohnHalleyGotway JohnHalleyGotway merged commit 018046a into main_v10.0-ref Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants