-
Notifications
You must be signed in to change notification settings - Fork 26
Update main_v10.0-ref after #1986 (MET v10.0.1) #1987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string or dictionary. (#1799)
…pport extra-tropical cyclone tracks not verified against BEST tracks.
* Updating compile script and associated config files for met-10.0.0 * Removing old config files * install_met_env.het * Updated orion file * Added stampede2 config file * Adding modulefiles for various machines
Bugfix 1801 main_v10.0 plot_tcmpr
* Recommended updates to clarify the use of projects and milestones for bugfixes. * Making details consistent across all issue templates.
…?id=99964) clarify the description of the obs_thresh option.
Adding text for GitHub Discussions
…de moves north to south
…id_latlon_to_laton Bugfix 1817 met v10.0 point2grid latlon to laton
…ile_list_parsing Bugfix 1508 met_v10.0 tc_gen file list parsing
* Per #1879, in Ensemble-Stat, only call add_grib_code() when point verification data is provided. * Per #1879, in the VarInfoGrib::add_grib_code() try doing a table lookup using the user-specified GRIB1 values first and then the default values second. Also, make the error message about no matches much more verbose.
Updated all template to include the addition of new alert labels
…on file for correct rendering
…tead of only the filename so that the function can tell whether or not the file exists. (#1953) Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Merging changes per review approval from @CPKalb, who technically does not have write access for the MET repo.
Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update main_v10.0-ref to get past diffs from the MET v10.0.1 bugfix release.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Getting past diffs caused by switching VERSION from "V10.0.0" to "V10.0.1".
The NB failed on 20211202 and all the diffs are in MTD in which version diffs are always flagged.
We should obviously enhance the diffing logic to handle this but for now, these diffs are expected.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
Update reference version, as expected.
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes