Skip to content

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Oct 5, 2021

Pull Request Testing

I manually ran the tc_stat commands listed there to confirm that the behavior is now as expected.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the code changes. I don't think rerunning a full regression test is warranted. Instead, we can just make sure the NB runs fine tonight.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

No changes.

  • Do these changes include sufficient testing updates? [No]

No changes. Rather than changing the NB results for main_v10.0, I updated the tests for the develop branch and think that's a sufficient level of testing.

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Tuesday 10/5/2021].

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my review for PR #1933 . Since @JohnHalleyGotway manually ran the tc_stat commands listed there and confirmed that the behavior is now as expected, I approve this PR.

@JohnHalleyGotway JohnHalleyGotway merged commit db2bb2d into main_v10.0 Oct 5, 2021
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_1932_main_v10.0_event_equal branch October 5, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TC-Stat event equalization logic to include any model name requested using -amodel.
2 participants