Bugfix 1932 main_v10.0 event_equal #1934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Please see issue Fix TC-Stat event equalization logic to include any model name requested using -amodel. #1932 and PR Bugfix 1932 develop event_equal #1933 for details of the problem and changes.
I manually ran the tc_stat commands listed there to confirm that the behavior is now as expected.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the code changes. I don't think rerunning a full regression test is warranted. Instead, we can just make sure the NB runs fine tonight.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
No changes.
No changes. Rather than changing the NB results for main_v10.0, I updated the tests for the develop branch and think that's a sufficient level of testing.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Tuesday 10/5/2021].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes