Feature 1914 dump_row #1929
Merged
Feature 1914 dump_row #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TAnalysisConfig_default contains a job array with one entry, a filter job that writes a file named filter_job.stat. Since the skill score index config files did NOT contains a jobs array, that default setting was getting passed along. By adding an empty jobs array to these config files, the hope is the default job can be overridden.
…ig file. Having an entry there that never actually gets exercised only causes confusion.
20 tasks
…AT-Analysis. Previously, if a config file was specified, it processed only those jobs. Now, if -job is used on that command line, it'll run that job. If not, it'll get jobs from the -config file, and if none of that, then it'll error out telling the user to specify at least one job. This is a good change, in all the MET tools, we want the command line options to override any config file options.
michelleharrold
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
@JohnHalleyGotway - I visually inspected the changes, and looks good to me. I approve.
|
Sorry for the confusion @michelleharrold. I'd created a DRAFT PR and listed your name on it. But I'm not actually ready for your review yet. The regression test actually failed and some code changes really are required. When I'm done testing those code changes and confirm that they don't break anything else, I'll ask for you to review again. |
michelleharrold
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
@JohnHalleyGotway - thanks for chatting about this on video chat. Based on changes, I apprive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Ran a full regression test comparing feature_1914_dump_row to develop on kiowa:
/d1/projects/MET/MET_pull_requests/met-10.1.0/met-10.1.0_beta3/feature_1914
And confirmed that:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
No additional testing needed. Just review the changes to the STAT-Analysis config files the top-level control logic of STAT-Analysis.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
No documentation changes needed. Writing the SSIDX output line type is a new feature in version 10.1.0.
Do these changes include sufficient testing updates? [Yes]
No additional testing needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Friday 10/1/21].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes