Skip to content

Bugfix 1801 main_v10.0 plot_tcmpr #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

Bugfix 1801 main_v10.0 plot_tcmpr #1805

merged 1 commit into from
May 21, 2021

Conversation

bikegeek
Copy link
Contributor

@bikegeek bikegeek commented May 21, 2021 •
edited
Loading

…pport extra-tropical cyclone tracks not verified against BEST tracks.

Pull Request Testing

  • Describe testing already performed for these changes:

    -on 'kiowa':
  1. Clone the task_1801_plot_tcmpr branch (to merge into main_v10.0)
  2. Create a $MET_INSTALL_DIR/share/met/Rscripts directory
  3. copy all the scripts in $SRC_DIR/MET/met/scripts/Rscripts into $MET_INSTALL_DIR/share/met/Rscripts
  4. Set MET_INSTALL_DIR env variable
  5. Run the following: Rscript $MET_INSTALL_DIR/share/met/Rscripts/plot_tcmpr.R -config /home/minnawin/METplus/parm/use_cases/model_applications/tc_and_extra_tc/Plotter_fcstGFS_obsGFS_RPlotting/TCMPRPlotterConfig_customize -lookin /home/minnawin/met-help/99800/tc_pairs/mlq2020010100.gfso.0002.tcst /home/minnawin/met-help/99800/tc_pairs/mlq2020010100.emx.0002.tcst /home/minnawin/met-help/99800/tc_pairs/mlq2020010100.cmc.0002.tcst -outdir /home/minnawin/met-help/99800/output/tcmpr_plots -no_ee -dep AMSLP-BMSLP,TK_ERR -plot MEAN,MEDIAN
  6. cd to the -outdir specified above and verify that mean and median plots are generated, with points for all three models: GFSO, EMX, and CMC on each plot.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    • perform the steps above

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • [ ]
    No documentation affected

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [5/21/2021].

    if possible, so it can be installed on 'hera' and Guang Ping can test.

Pull Request Checklist

See the METplus Workflow for details.

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s), Project(s), and Milestone
  • After submitting the PR, select Linked Issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek
Github Issue #1801: Comment out code that checks for BEST track to su…
de18798 
…pport extra-tropical cyclone tracks not verified against BEST tracks.
@bikegeek bikegeek added component: user support User support issue requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work priority: high requestor: METplus Team METplus Development Team labels May 21, 2021
@bikegeek bikegeek added this to the met-10.0.1 (bugfix) milestone May 21, 2021
@bikegeek bikegeek self-assigned this May 21, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Github Issue #1801: Comment out code that checks for BEST track to su… Feature 1801 plot_tcmpr May 21, 2021
@JohnHalleyGotway JohnHalleyGotway removed component: user support User support issue priority: high requestor: METplus Team METplus Development Team requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work labels May 21, 2021
@JohnHalleyGotway JohnHalleyGotway linked an issue May 21, 2021 that may be closed by this pull request
Fix the plot_tcmpr.R script to plot extra-tropical cyclone tracks not verified against BEST tracks. #1801
Closed
21 tasks
@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented May 21, 2021 •
edited
Loading

Note that I made the following changes to this PR:

  • Renamed the PR as "Bugfix 1801 main_v10.0 plot_tcmpr" to follow the conventions listed in the bugfix checklist. Please name branches with either the "feature_" or "bugfix_" prefix, and not "task_". None of the issue checklists indicate that.
  • Removed the assignee and all labels. We do not use those for PR's.
  • The milestone of "met-10.0.1 (bugfix)" is correct.
  • Added this PR to the organization level "METplus Version 4.0 Support" project which we use for all bugfixes.
  • Added a link to the source issue Fix the plot_tcmpr.R script to plot extra-tropical cyclone tracks not verified against BEST tracks. #1801.

I see that this PR makes a fix for main_v10.0 to be included in a met-10.0.1 bugfix release.
Are you also planning to submit a PR to update it in the develop branch for inclusion in the next official release, met-10.1.0?

@JohnHalleyGotway JohnHalleyGotway changed the title Feature 1801 plot_tcmpr Bugfix 1801 main_v10.0 plot_tcmpr May 21, 2021
JohnHalleyGotway
JohnHalleyGotway approved these changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out these lines for a bugfix version 10.0.1 is probably easiest and fine.
In the PR for the develop branch, recommend that we just remove those lines entirely instead of commenting them out. I generally avoid having commented out code cluttering up the logic.

I approve of these changes.

@bikegeek
Copy link
Contributor Author

Leaving code commented out in this version.

@bikegeek bikegeek closed this May 21, 2021
@bikegeek bikegeek reopened this May 21, 2021
@bikegeek bikegeek merged commit e7b3bcd into main_v10.0 May 21, 2021
@bikegeek bikegeek deleted the task_1801_plot_tcmpr branch May 21, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnHalleyGotway JohnHalleyGotway JohnHalleyGotway approved these changes

@jprestop jprestop Awaiting requested review from jprestop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MET 10.0.1 (bugfix)
Development

Successfully merging this pull request may close these issues.

Fix the plot_tcmpr.R script to plot extra-tropical cyclone tracks not verified against BEST tracks.
2 participants
@bikegeek @JohnHalleyGotway