Skip to content

Bugfix 1484 develop file_list #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2020
Merged

Bugfix 1484 develop file_list #1486

merged 4 commits into from
Sep 9, 2020

Conversation

JohnHalleyGotway
Copy link
Collaborator

Larger and better set of fixes for this issue in develop.

@JohnHalleyGotway
Per #1484, porting the same bugfix over from master_v9.1 to the devel…
4b61053 
…op branch. This is to sync them up. However, I'd like to find a more robust solution for distinguishing file lists.
@JohnHalleyGotway
Per #1484, split vx_util/get_filenames.cc into 2 pieces and move file…
7b0f8e3 
… list parsing functionality into vx_data2d_factory/parse_file_list.cc. Had to update includes for tc_gen and gsidens2orank to handle this change. Next, I need to tweak the parse_file_list logic slightly.
@JohnHalleyGotway
Per #1484, after moving the parse_file_list() functions, the NetCDF l…
b5682a2 
…ibraries need to be added to the gsi_tools linker lists.
@JohnHalleyGotway
Per #1484, update parse_ascii_file_list() to avoid parsing gridded da…
c1d3114 
…ta files as being ASCII file lists.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0 milestone Sep 9, 2020
@JohnHalleyGotway JohnHalleyGotway linked an issue Sep 9, 2020 that may be closed by this pull request
Fix ascii file list parsing logic. #1484
Closed
19 tasks
georgemccabe
georgemccabe approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that this change would involve checking for a known file type as part of the check for a file list. This sounds good to me.

georgemccabe
georgemccabe approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that this change would involve checking for a known file type as part of the check for a file list. This sounds good to me.

@JohnHalleyGotway JohnHalleyGotway merged commit e17bc24 into develop Sep 9, 2020
@JohnHalleyGotway JohnHalleyGotway deleted the bugfix_1484_develop_file_list branch September 9, 2020 19:06
@JohnHalleyGotway JohnHalleyGotway mentioned this pull request Sep 26, 2020
Closed
19 tasks
JohnHalleyGotway added a commit that referenced this pull request Sep 26, 2020
@JohnHalleyGotway
As described in #1484 comment #1484 (comment), port bugfix from PR #1486
ab97e68 
 into the main_v9.1 branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgemccabe georgemccabe georgemccabe approved these changes

@CPKalb CPKalb Awaiting requested review from CPKalb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MET 10.0.0
Development

Successfully merging this pull request may close these issues.

Fix ascii file list parsing logic.
2 participants
@JohnHalleyGotway @georgemccabe