-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Enhancement
With #3189 , MET regression tests are using logic from metplus/util/diff_util.py. The nightly test scripts will be looking for the METplus directory assigned to the METPLUS_DIR variable in internal/scripts/environment/development.seneca.
In order to apply the latest differencing logic, this local METplus develop branch should be updated regularly.
Per @georgemccabe , one option would be to install the METplus repo in the conda environments the with -e pip install option so pulling changes in the source code automatically apply to the installed version, so these would benefit from regular (daily?) updates from develop. However, this approach makes reproducibility difficult because you won't be able to see what was used on a given day.
Another option would be to incorporate the checkout of METplus within the MET nightly build scripts so we have a clear snapshot of what was used each day. This might get us into a weird circular dependency issue since we eventually want to fix/recreate the build scripts in the METplus repo that are intended to obtain the other components, like MET, METdataio, METcalcpy, and METplotpy.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
- Add a checkbox for each sub-issue here.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Review default alert labels
- Select component(s)
- Select priority
- Select requestor(s)
Milestone and Projects
- Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
- For a MET-X.Y.Z version, select the MET-X.Y Development project
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y Development project for development toward the next coordinated release - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status