Describe the Problem

Compiling the MET-12.1.0-rc1 release with Intel compilers (Intel classic on WCOSS and Intel OneAPI on seneca) revealed the following issues:

1. Classic compilers warn about missing omp from this statement:

pair_data_point.cc(882): warning #161: unrecognized #pragma
#pragma for reduction(+: n_skip)

• Found/fixed 2 instances of this.

2. OneAPI compilers warn about implicitly-defined namespace:

enum_parser.yy:15:17: warning: using directive refers to implicitly-defined namespace 'std'

• The namespace should be defined after all includes.
• Found/fixed 1 instance of this in enum_parser.yy.
• Found/fixed MANY instances of this in the test code, although that is not actually compiled for installations.

3. The compilation of the vx_grid test utilities fail when MET_DEVELOPMENT is set and --disable-ugrid is used.

• Fix the Makefiles internal/test_util/libcode/vx_grid to only compile KDTree utilities when ENABLE_UGRID is set.

4. Enhance the MET compilation script adding the ability to disable OpenMP.
5. Modify the configuration files and modulefiles as necessary for WCOSS2 installation.

Expected Behavior

MET should compile with Intel classic compilers without any errors.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Review default alert labels
• Select component(s)
• Select priority
• Select requestor(s)

Milestone and Projects

• Select Milestone as the next bugfix version
• Select METplus-X.Y Support project for support of the current coordinated release
• Select MET-X.Y Development project for development toward the next coordinated release

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy
  None needed.

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the next bugfix version
  Select: METplus-X.Y Support project for support of the current coordinated release
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Development issue
  Select: Milestone as the next official version
  Select: MET-X.Y Development project for development toward the next coordinated release
• Close this issue.