Skip to content

Bugfix: Fix Ensemble-Stat's handling of climo data when verifying ensemble-derived probabilities #2856

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Problem

Based on dtcenter/METplus#2536.

See details in seneca:/d1/projects/METplus/discussions/2536/es_example/run_es.sh and add them here.

In ensemble_stat.cc:

@@ -2244,6 +2244,7 @@ void do_pct_cat_thresh(const EnsembleStatVxOpt &vx_opt,
 
       // Re-initialize
       pd_pnt.erase();
+      pd_pnt.set_climo_cdf_info_ptr(&vx_opt.cdf_info);
 
       // Process the observations
       for(i_obs=0; i_obs<pd_ens.n_obs; i_obs++) {
@@ -2342,6 +2343,7 @@ void do_pct_cdp_thresh(const EnsembleStatVxOpt &vx_opt,
 
       // Re-initialize
       pd_pnt.erase();
+      pd_pnt.set_climo_cdf_info_ptr(&vx_opt.cdf_info); 

And also consider updating the default Ensemble-Stat config file:

+++ b/data/config/EnsembleStatConfig_default
@@ -158,7 +158,7 @@ climo_stdev = {
 // May be set separately in each "obs.field" entry
 //
 climo_cdf = {
-   cdf_bins    = 10;
+   cdf_bins    = 1;

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Status

🏁 Done

Relationships

None yet

Development

No branches or pull requests

Issue actions