Skip to content

Bugfix: Fix the Point-Stat CNT header line typo causing duplicate SI_BCL column names  #2730

@John-Sharples

Description

@John-Sharples

Describe the Problem

Small issue one of the devs here at BoM noticed:

point_stat cnt file has a repeated header: Last 2 header values are "SI_BCL", but last one should be "SI_BCU" instead, as per docs here: https://met.readthedocs.io/en/latest/Users_Guide/point-stat.html#id11

Expected Behavior

Environment

To Reproduce

sudo docker run -it dtcenter/metplus:6.0.0-beta1 /bin/bash

pushd /met/MET-develop/scripts

export TEST_OUT_DIR=/metplus/OUTPUT

mkdir -p ${TEST_OUT_DIR}/point_stat

point_stat \
   ../data/sample_fcst/2007033000/nam.t00z.awip1236.tm00.20070330.grb \
   ${TEST_OUT_DIR}/pb2nc/sample_pb.nc \
   config/PointStatConfig \
   -point_obs ${TEST_OUT_DIR}/ascii2nc/sample_ascii.nc \
   -outdir ${TEST_OUT_DIR}/point_stat -v 2

cat ${TEST_OUT_DIR}/point_stat/point_stat_360000L_20070331_120000V_cnt.txt

Relevant Deadlines

NONE

Funding Source

NONE

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Status

🏁 Done

Relationships

None yet

Development

No branches or pull requests

Issue actions