Describe the Enhancement

TC-Diag development history:

1. MET-12.0.0-beta2: Issue Enhance TC-Diag to actually compute and write diagnostics #2550 and PR Feature #2550 compute_diagnostics #2728 enhanced the TC-Diag tool to actually compute tropical cyclone diagnostics and write output files.
2. MET-12.0.0-beta3: Issue Enhance TC-Diag to use tc_diag_driver version 0.11.0 #2769 and PR Feature #2769 tc_diag_driver_v0.11.0 #2812 updated the Python driver code, addressed unit issues, and fixed the diagnostic file formatting.
3. Note that issue Enhance TC-DLand to use updated NHC land definition data #2751 will also impact the TC-Diag tool but is documented as a separate issue.

The following tasks were not completed for #2769 and should be addressed during the beta4 development cycle:

• Investigate why the computed diagnostics DO NOT MATCH @robertdemariacira. As discussed on 11/1/23:
  • It is OK if diag values differ by 1 due to rounding.
  • There are clearly problems with the winds.
  • @JohnHalleyGotway and @robertdemariacira will coordinate on testing/debugging.
• Update unit_tc_diag.xml to run a realistic HWRF parent + nest example. Be sure to test with with and without MET_PYTHON_EXE set. Use Hurricane Ian example for which we have diagnostics output and @KathrynNewman is providing gridded HWRF test data. Note that d01 should be used as the "parent" and d03 as the "nest" data source.
• MET-12.0.0-beta3 replaced writing temporary Python files in NetCDF format with JSON + NumPy serialization. TC-Diag still writes NetCDF cylindrical coordinate files for the Python tc_diag_driver code to read. Investigate whether or not this approach works on NOAA machines (like jet) where there was a NetCDF conflict. If not, consider always making a system call to Python (with MET_PYTHON_EXE set) rather than actually embedding it.

Additional task list (last updated based on Nov 29, 2023 project meeting):

• Keep NetCDF variable long names consistent with the ones listed in this Google Doc. See @jvigh.
• Enhance the NetCDF diagnostics output to report data in more typical units (e.g. use C rather than 10C). However, recommend keeping knots rather than switching to m/s.
• Run the TC-Diag NetCDF output through the https://ioos.noaa.gov CF-convention compliance checker. It may not be possible to achieve full compliance, but recommend getting as close as reasonably possible.
• Parallelize the processing of valid times. Simple OpenMP does not work. Global python instance is a problem.
• Update documentation @JohnHalleyGotway:
  • Describe CIRA and NetCDF diag outputs.
  • Update Appendix F with TC-Diag python embedding info.
• Review existing configuration options and documentation for details about vortex removal. Make any necessary updates since it will not be included in MET version 12.0. See issue Enhance TC-Diag to support vortex removal #2752.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
See related issues:

• Enhance TC-Diag to use tc_diag_driver version 0.11.0 #2769
• Enhance TC-DLand to use updated NHC land definition data #2751
• Enhance TC-Diag to support vortex removal #2752

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2770043

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Review default alert labels
• Select component(s)
• Select priority
• Select requestor(s)

Milestone and Projects

• Select Milestone as the next official version or Backlog of Development Ideas
• For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy
  No impacts currently.

Enhancement Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the next official version
  Select: MET-X.Y.Z Development project for development toward the next official release
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.