-
Notifications
You must be signed in to change notification settings - Fork 26
Closed
Labels
component: repository maintenanceRepository maintenance issueRepository maintenance issuepriority: mediumMedium PriorityMedium Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: taskAn actionable item of workAn actionable item of work
Milestone
Description
Describe the Task
As of January 24, 2024, the following warning messages began appearing on the MET GitHub action workflow runs:
[Build Documentation](https://github.com/dtcenter/MET/actions/runs/7642630271/job/20822701483)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Our call to actions/checkout@v3
triggers this warning message, as do other similar actions. Recommend upgrading action version numbers as needed to move past this warning. Make these change in both the develop and main_v11.1 branches.
Can use the following commands to update:
cd .github/workflows
for file in `ls *.yml`; do
cat $file | \
sed 's%actions/checkout@v3%actions/checkout@v4%g' | \
sed 's%actions/upload-artifact@v3%actions/upload-artifact@v4%g' | \
sed 's%actions/download-artifact@v3%actions/download-artifact@v4%g' | \
sed 's%actions/setup-python@v4%actions/setup-python@v5%g' | \
sed 's%actions/github-script@v6%actions/github-script@v7%g' > tmp;
mv tmp $file;
done
Time Estimate
2 hours.
Sub-Issues
Consider breaking the task down into sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Review default alert labels
- Select component(s)
- Select priority
- Select requestor(s)
Milestone and Projects
- Select Milestone as the next official version or Backlog of Development Ideas
- For the next official version, select the MET-X.Y.Z Development project
Define Related Issue(s)
Consider the impact to the other METplus components.
- METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy
If this is successful, recommend that the other METplus repo's be updated in a similar way.
Task Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
component: repository maintenanceRepository maintenance issueRepository maintenance issuepriority: mediumMedium PriorityMedium Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: taskAn actionable item of workAn actionable item of work
Type
Projects
Status
🏁 Done