Skip to content

Repository cleanup of stale code and configuration consistency #2776

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Task

During development for #2547, @georgemccabe compiled MET using CMake with CLion and uncovered a few files that are not actually being compiled. This issue is to review the source code to:

  1. Remove any stale files that are not actually compiled by the Makefile.am file in their directory.
  2. Add/update Makefile.am files, as needed.
  3. Update the atlast/ecKit settings in configure.ac for consistency with other optional library handling.

Ran the following to find .cc files not being compiled:

for file in `find ./ -name "*.cc"`; do
  short=`basename $file`;
  egrep -r "( |\t)${short}( |$)"  `find ./ -name Makefile.am` > t;
  n=`cat t | wc -l`;
  if [ $n != 1 ]; then
    echo $n $short;
  fi;
done

That flagged the following to be investigated:

0 test_read_rmw.cc      // --> Updated internal/test_util/libcode/vx_tc_util/Makefile.am to compile it
0 test_numpy.cc         // --> Added missing internal/test_util/libcode/vx_python3_utils/Makefile.am to compile it
0 test_get.cc           // --> Added missing internal/test_util/libcode/vx_python3_utils/Makefile.am to compile it
0 wwmca_utils.cc        // --> Removed .h and .cc
0 rmw_analysis_utils.cc // --> Removed .h and .cc
0 prob_pair_info.cc     // --> Removed .h and .cc

Time Estimate

4 hours.

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions