Skip to content

Bugfix: Investigate unexpected number of derived HPBL observations in PB2NC #2687

@jprestop

Description

@jprestop

Describe the Problem

When committing ONLY a filename change directly in the develop branch, the GitHub Actions run produced a failure at the "Check for Differences" step. Asking about it on GitHub, @JohnHalleyGotway indicated that these derived PBL obs also recently caused diffs when we switched METbaseimage to Debian 12:
https://github.com/dtcenter/MET/actions/runs/6101796818/job/16560081693?pr=2675
The PBL derivation doesn't seem to be as repeatable as it should be. We need to look into the details of calpbl.f to debug and tighten up the logic.
@georgemccabe noted that this issue is the likely cause of the use case diffs as described in Enhancement: Improve PBL use case to generate reproducible results #2246.

Expected Behavior

The 9 missing derived HPBL obs should not be missing.

python MET-develop/scripts/python/utility/print_pointnc2ascii.py nam.20210311.t00z.prepbufr.tm00.pbl_TRUTH.nc > nam.20210311.t00z.prepbufr.tm00.pbl_TRUTH.txt

python MET-develop/scripts/python/utility/print_pointnc2ascii.py nam.20210311.t00z.prepbufr.tm00.pbl_OUTPUT.nc > nam.20210311.t00z.prepbufr.tm00.pbl_OUTPUT.txt

diff nam.20210311.t00z.prepbufr.tm00.pbl_TRUTH.txt nam.20210311.t00z.prepbufr.tm00.pbl_OUTPUT.txt

Here are the differences:

99d98
< ADPUPA 70398   20210311_000000 55.05 -131.5900   35 HPBL   NA 0 9  103.87126160
102d100
< ADPUPA 70326   20210311_000000 58.68 -156.6700    8 HPBL   NA 0 9  130.87126160
108d105
< ADPUPA 70273   20210311_000000 61.16 -149.9900   52 HPBL   NA 0 9   86.87126160
117d113
< ADPUPA 71957   20210311_000000 68.32 -133.5300  103 HPBL   NA 0 9   35.87126160
132d127
< ADPUPA 76903   20210311_000000 14.88  -92.3000  119 HPBL   NA 0 9   19.87126160
145d139
< ADPUPA 72240   20210311_000000 30.13  -93.2200    5 HPBL   NA 0 9  133.87126160
377d370
< ADPUPA 70261   20210311_000000 64.82 -147.8800  134 HPBL   NA 0 9    4.87126160
383d375
< ADPUPA 71917   20210311_000000 80.00  -85.9300   10 HPBL   NA 0 9  128.87126160
386d377
< ADPUPA 71082   20210311_000000 82.50  -62.3500   76 HPBL   NA 0 9   62.87126160

Environment

Describe your runtime environment:
GitHub Actions

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

Beta2

Funding Source

2792543 - NOAA Base

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select MET-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions