Skip to content

Bugfix: Resolve compilation problems due to need for -std=c++11 #2531

@jprestop

Description

@jprestop

Describe the Problem

We are experiencing problems with the compilation of MET-11.1.0-beta2 on Hera, seemingly due to recent SonarQube changes.

Expected Behavior

Resolve the problems to get a successful compilation on Hera. Changes require:

  • Adding -std=c++11 to CXXFLAGS in configure.ac
  • Adding "std::" to isnan in various places

Environment

Describe your runtime environment:
1. Machine: Hera
2. OS: CentOS Linux 7 rhel fedora
3. Compilers: Using icc (ICC) 2021.5.0 20211109; gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)

To Reproduce

Describe the steps to reproduce the behavior:
As the role.metplus user, in /contrib/met/11.1.0-beta2, run "./compile_MET_all.sh install_met_env_met_only.hera" or to build manually while testing changes, run "./build_manually.sh"

Relevant Deadlines

ASAP

Funding Source

2700042

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions