-
Notifications
You must be signed in to change notification settings - Fork 26
Closed
Labels
MET: Python Embeddingcomponent: documentationDocumentation issueDocumentation issuepriority: mediumMedium PriorityMedium Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: bugFix something that is not workingFix something that is not working
Milestone
Description
In Pandas, str
is not a valid dtype. It should be string
:
MET/scripts/python/met/point.py
Line 677 in 22fbca7
dtype={'typ':'str', 'sid':'str', 'vld':'str', 'var':'str', 'qc':'str'}).values.tolist() |
MET/scripts/python/met/mprbase.py
Line 11 in 22fbca7
skiprows=1, dtype=str): |
In appendixF, the point_stat
Python embedding for point data example is incorrect for the command line and should have the obs dict entry removed:
MET/docs/Users_Guide/appendixF.rst
Lines 499 to 518 in 22fbca7
point_stat 'PYTHON_NUMPY' 'PYTHON_NUMPY' PointStat_config -outdir /path/to/output | |
.. code-block:: none | |
:caption: PointStat Config with Dual Python Embedding | |
fcst = { | |
field = [ | |
{ | |
name = "/path/to/fcst/python/script.py python_arg1 python_arg2"; | |
} | |
]; | |
} | |
obs = { | |
field = [ | |
{ | |
name = "/path/to/obs/python/script.py python_arg1 python_arg2"; | |
} | |
]; | |
} |
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Organization level Project for support of the current coordinated release
- Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description>
- Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Close this issue.
Metadata
Metadata
Assignees
Labels
MET: Python Embeddingcomponent: documentationDocumentation issueDocumentation issuepriority: mediumMedium PriorityMedium Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: bugFix something that is not workingFix something that is not working