-
Notifications
You must be signed in to change notification settings - Fork 26
Closed
Labels
component: code cleanupCode cleanup and maintenance issueCode cleanup and maintenance issuepriority: mediumMedium PriorityMedium Priorityreporting: DTC AF METplusAir Force METplus ProjectAir Force METplus Projectrequestor: USAFUnited States Air ForceUnited States Air Forcetype: taskAn actionable item of workAn actionable item of work
Milestone
Description
Describe the Task
SonarQube flags the use of NULL
instead of nullptr
as a critical code smell. This task is to find/replace all instances of NULL
with nullptr
instead.
Here's the SonarQube explanation:
Before C++11, the only way to refer to a null pointer was by using the integer literal 0, which created ambiguity with regard to whether a pointer or an integer was intended. Even with the NULL macro, the underlying value is still 0.
C++11 introduced the keyword nullptr, which is unambiguous and should be used systematically.
Time Estimate
2 hours.
Sub-Issues
Consider breaking the task down into sub-issues.
No sub-issues.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2771021
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Task Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
component: code cleanupCode cleanup and maintenance issueCode cleanup and maintenance issuepriority: mediumMedium PriorityMedium Priorityreporting: DTC AF METplusAir Force METplus ProjectAir Force METplus Projectrequestor: USAFUnited States Air ForceUnited States Air Forcetype: taskAn actionable item of workAn actionable item of work