-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Enhancement
As reported by @halperin-erau, NOAA NHC has changed how it issues TC genesis probabilities in the NHC Graphical Tropical Weather Outlook (GTWO) area shapefiles, and TC-Gen should be modified to accommodate those changes. As of MET version 11.0.0, the TC-Gen tool assumes that the GTWO files always define 2, 5, and 7 day genesis probabilities, in that order. However, as of 15 May 2023, NHC now issues 2-day and 7-day genesis probabilities. The 5-day genesis probability has been discontinued.
The hard-coded setting can be seen on this line of code in the tc_gen.h
header file. These lead time values listed in hours correspond to 2, 5, and 7 days.
This task is to update the logic of tc_gen.cc
somewhere around this line of code to also parse the number of days from the database file (.dbf) rather than assuming 2, 5, and 7 day probs.
The gis_dump_dbf
tool shows that the day values are included in the sub-record field_name
entries:
> gis_dump_dbf MET_test_input/tc_data/genesis/shape/atl/202108070507/gtwo_areas_202108062331.dbf
...
| SubRecord 2
| | field_name = "PROB2DAY"
...
| SubRecord 4
| | field_name = "PROB5DAY"
...
Record 0 ...
| BASIN = "Atlantic"
| AREA = "1"
| PROB2DAY = "30%"
| RISK2DAY = "Low"
| PROB5DAY = "50%"
| RISK5DAY = "Medium"
Fixing this will require parsing the integer number of days from the field_name
rather than just assuming the first is 2 days, second is 5 days, and third is 7 days.
Time Estimate
1 day
Sub-Issues
Consider breaking the enhancement down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.