-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Problem
The config.tab.cc source code was edited...
From: yystate = 0;
To: yystate = 8;
Initializing the parsing state to a value of 8 enables it to successfully parse empty configuration files without error. The default initial value of 0 produces a runtime error. PR #2291 for issue #2237 made this change and added a test for processing empty config files to unit_stat_analysis_ps.xml
. That test fails sporadically in the MET Nightly Build.
The MET Nightly Build is run with MET_DEVELOPMENT = true
and that triggers the ENABLE_DEVELOPMENT
setting in the configuration file. When the develop branch is checked out, sometime the config.tab.yy
file has a timestamp newer than the config.tab.cc
file. When make
is run, the triggers config.tab.cc to be regenerated from config.tab.yy. And each time it's regenerated, that initial yystate value of 8 gets reset to the default value of 0.
The proposed fix is the update Makefile.am
to explicitly patch the initial yystate value immediately after its generated. It's not a very elegant fix, but should produce the desired result.
Expected Behavior
MET should be able to process empty config files without error and the NB should not fail.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Organization level Project for support of the current coordinated release
- Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description>
- Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Close this issue.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status