Bugfix: AERONET the lat/lon is not changed with different station ID #2493
Description
Replace italics below with details for this issue.
Describe the Problem
The AREONET version 3 has a variation of 6 line header which has lat/lon/elv columns. The lat/lon/elv should be updated when the SiteName is changed: "Tucson 32.233002 -110.953003 779" to "GSFC 38.9925 -76.839833 87"
The command at seneca:
/d1/projects/MET/MET_regression/develop/NB20230328/MET-develop/bin/ascii2nc /d1/projects/METplus/discussions/1888/Discussion1888/20230309.lev15 test_aeronet.nc -format aeronetv3
The AREONET input
AERONET_Site_Name Site_Latitude(Degrees) Site_Longitude(Degrees) Site_Elevation(m)
Tucson 32.233002 -110.953003 779
Tucson 32.233002 -110.953003 779
Tucson 32.233002 -110.953003 779
GSFC 38.9925 -76.839833 87
GSFC 38.9925 -76.839833 87
The output of print_pointnc2ascii.py shows the same lat/lon/elv of "Tucson" for "GSFC"
AERONET_AOD Tucson 20230309_235841 32.2330 -110.9530 779 AOD NA 550.00 NA 0.02957695
AERONET_AOD GSFC 20230309_121903 32.2330 -110.9530 779 AOD NA 1640.00 NA 0.00589800
AERONET_AOD GSFC 20230309_121903 32.2330 -110.9530 779 AOD NA 1020.00 NA 0.01574700
Expected Behavior
Provide a clear and concise description of what you expected to happen here.
The output of print_pointnc2ascii.py should be:
AERONET_AOD Tucson 20230309_235841 32.2330 -110.9530 779 AOD NA 550.00 NA 0.02957695
AERONET_AOD GSFC 20230309_121903 38.9925 -76.8398 87 AOD NA 1640.00 NA 0.00589800
AERONET_AOD GSFC 20230309_121903 38.9925 -76.8398 87 AOD NA 1020.00 NA 0.01574700
Environment
Describe your runtime environment:
1. Machine: Linux Workstation, seneca
2. OS: RedHat Linux
3. Software version number(s): MET v11.0 and v11.1
To Reproduce
Describe the steps to reproduce the behavior:
- bin/ascii2nc /d1/projects/METplus/discussions/1888/Discussion1888/20230309.lev15 test_aeronet.nc -format aeronetv3
- <MET_BASE>/utility/print_pointnc2ascii.py test_aeronet.nc > dump_aeronet.txt
- Check the lat/lon/elv of Tucson and GSFC
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Organization level Project for support of the current coordinated release
- Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description> - Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description> - Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Close this issue.