-
Notifications
You must be signed in to change notification settings - Fork 26
Closed
Labels
MET: Python Embeddingpriority: mediumMedium PriorityMedium Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: enhancementImprove something that it is currently doingImprove something that it is currently doing
Milestone
Description
There are some inconsistencies with the Python environment that is used to run Python Embedding in MET.
- If the X.Y version of the Python instance in the user's PATH matches the X.Y version of Python used to install MET, then the packages from the user's version are used instead of the installed version. This means that if a required packages like numpy is not available in the user's version, then MET Python Embedding will fail unless MET_PYTHON_EXE is set.
- Python Embedding scripts that read point obs need to import met_point_obs.py, which is not available in the python path. There is an existing MET issue (Enhance the MET point processing tools to read the Python 'point_data' variable instead of just 'met_point_data'. #2285) to support reading point_data directly into all MET tools that would resolve this issue.
- It appears that the Python executable in the user's path is what is used to actual call Python Embedding logic (w/o MET_PYTHON_EXE), even though it may use the Python packages from the installed version (if the X.Y versions don't match). It would be good to ensure that the actual installed version is actually used in this case.
Describe the Enhancement
Provide a description of the enhancement request here.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
- Add a checkbox for each sub-issue here.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
MET: Python Embeddingpriority: mediumMedium PriorityMedium Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: enhancementImprove something that it is currently doingImprove something that it is currently doing