-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Problem
Pull Request #2344 for issue #1943 added the override
keyword to src/libcode/vx_seeps/seeps.h
:
void clear() override;
This change results in the unexpected adoption of the C++11 standard. And that change prompted this dtcenter/METplus#1991 discussion. While C++11 is very widely used and supported, some very old compiler versions do not support it.
Since the use of override
is not required, recommend removing it from both the main_v11.0 and develop branches. And consider adopting and documenting the C++11 standard in a more formal, thorough way in the future.
While this will be changes in the main_v11.0 branch, it does NOT warrant a new bugfix release. Recommend waiting for additional bugfixes prior to cutting the 11.0.1 release.
Expected Behavior
MET should not yet require the C++11 standard.
Environment
Describe your runtime environment:
MET-11.0.0 compilation fails on Cray running GNU version 4.3.0.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Organization level Project for support of the current coordinated release
- Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description>
- Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Close this issue.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status