Skip to content

Remove namespace specification from header files #2227

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Enhancement

This issue was raised on 8/8/2022 during a Modern C++ weekly meeting. Please see the following discussion:
https://stackoverflow.com/questions/1265039/using-std-Namespace

Based on this, using namespace ... should never be included in a header file. However, of the 467 header files in the MET codebase, using namespace std and using namespace netCDF appears in 39 and 32 of them, respectively.

This task is to remove them from the header files and make any updates required to ensure the code compiles and all existing tests run.

Time Estimate

2 days?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
Non needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Per Tara, split across keys

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions