-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Enhancement
#1815 enhanced MET-11.0.0-beta2 to support the specification of NetCDF level strings with the VALUE of the dimensions rather the just the INDEX of the dimensions. @robdarvell tested out this new functionality in beta2 and provided feedback to refine the functionality.
For a variable with a dimension that contains 24 levels, he requested level='(@23,*,*)';
. He expected this call to fail since the corresponding coordinate variable does NOT contain a value of 23. However running plot_data_plane in this way ran without error and it just used 23 as the INDEX for that dimension.
Recommend that we tweak the logic for parsing these levels strings. If the sting begins with an '@' character always interpret it as a VALUE and never as an INDEX.
It is not clear to me how the converse should be handled. For simplicity, should the lack of an '@' character force the interpretation to be as an INDEX and not a VALUE? The issue here is the time dimension. MET version 10.1.0 allows for the time dimension to be specified as a formatted string. For for this NetCDF variable data(time,lat,lon)
the level='(20220807_120000,*,*)';
string correctly retrieves the data. In MET 11.0.0-beta2, level='(@20220807_120000,*,*)';
now also works.
@hsoh-u can we make the presence of the leading @ character optional for time strings to preserve backward compatibility?
But make their presence required when specifying values for non-time strings?
@robdarvell any opinion on this detail?
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
No sub-issues needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
2799991
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required: @robdarvell should review
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.