-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Replace italics below with details for this issue.
Describe the Problem
Provide a clear and concise description of the bug here.
Generated MET point obs NetCDF file by ioda2nc contains truncated station ids. The station id comes form "report_identifier@MetaData" variable. An IODA input file (at seneca:/d1/personal/kalb/ioda/raob_all_v1_20201215T1200Z.nc4) has "station_id@MetaData" variable instead of "report_identifier@MetaData". The MET's NetCDF dimension is 40 bytes (enough to contain the original station IDs).
The metadata variable for station_id@MetaData variable:
Station_ids from the IODA:
station_id@MetaData =
"89009 23 4gIUS02",
"89009 23 4gIUS04",
"89009 23 4gIUS02",
...
"68538-99-9gIUK02",
"68538-99-9gIUS10",
"68538-99-9gIUK04",
"68538-99-9gIUK06",
Generated MET point obs NetCDF file.
hdr_sid_table =
"89009 23",
"89664 23",
"89664 23 4n",
"89625 23",
...
"68538-99-9gIUK02",
"68538-99-9gIUS10",
"68538-99-9gIUK04",
"68538-99-9gIUK06",
Expected Behavior
Provide a clear and concise description of what you expected to happen here.
Do not truncate the string (just strip out trailing white space characters).
Environment
Describe your runtime environment:
*1. Machine: Linux Workstation (seneca)
*2. OS: RedHat Linux
3. Software version number(s) 11.0 beta2
To Reproduce
Describe the steps to reproduce the behavior:
- login to seneca
- Modify IODA2NC config
metadata_map = [
{ key = "message_type"; val = "msg_type,station_ob"; },
{ key = "station_id"; val = "station_id,report_identifier"; },
{ key = "pressure"; val = "air_pressure,pressure"; },
{ key = "height"; val = "height,height_above_mean_sea_level"; },
{ key = "elevation"; val = ""; }
];
- run ioda2nc
./ioda2nc /d1/personal/hsoh/data/IODA_files/raob_all_v1_20201215T1200Z.nc4 out_raob_all_air_temperature.nc /d1/personal/hsoh/git/features/feature_2215_ioda2nc_message_type/MET/share/met/config/IODA2NCConfig -obs_var air_temperature -v 4
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2799991
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Organization level Project for support of the current coordinated release
- Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next bugfix version
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description>
- Fix the bug and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Organization level software support Project for the current coordinated release
Select: Milestone as the next bugfix version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Close this issue.