-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the New Feature
Ascii2nc has has options for time summary such as max, mean, etc. However, for precipitation accumulations, sum is needed. Since support for the time_summary option is handled in the MET library code, adding the "sum" option there will make it available to all of the point pre-processing tools.
Whereas the min, max, and mean functions are less susceptible to missing data, the "sum" option is highly susceptible to it. Missing observation reports could produce very different results.
This can be mitigated by setting vld_thresh = 1.0 to require that all expected input data actually be present in order to produce a result. Recommend adding a sanity check to the code... if "sum" requested but vld_thresh is not set to 1.0, print a warning message to the user recommending the set vld_thresh = 1.0 and explaining the risks.
Acceptance Testing
List input data types and sources.
Describe tests required for new functionality.
Time Estimate
1 day.
Sub-Issues
Consider breaking the new feature down into sub-issues.
No sub-issues needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
New Feature Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.