Skip to content

Print ASCII2NC warning message about python embedding support not being compiled #2277

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Enhancement

Running ascii2nc with python embedding without optional python embedding support being compiled results in this error message:

bin/ascii2nc -format python 'scripts/python/read_ascii_point.py data/sample_obs/ascii/sample_ascii_obs.txt' out.nc
...
ERROR  : set_format() -> unsupported ASCII observation format "python".

Whereas, doing the same with plot_data_plane provides a much better error message:

bin/plot_data_plane PYTHON_NUMPY plot.ps 'name="scripts/python/read_ascii_numpy.py data/python/fcst.txt FCST";'
...
ERROR  : Met2dDataFileFactory::new_met_2d_data_file() -> Support for Python has not been compiled!
ERROR  : To run Python scripts, recompile with the --enable-python option.

Recommend enhancing the ascii2nc error message to make it more clear, and consider reviewing other MET tools that process python point observations as well.

Time Estimate

4 hours.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @JohnHalleyGotway
  • Select scientist(s) or no scientist required: No scientist needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions