-
Notifications
You must be signed in to change notification settings - Fork 26
Labels
MET: Configurationpriority: mediumMedium PriorityMedium Priorityrequestor: NOAA/EMCNOAA Environmental Modeling CenterNOAA Environmental Modeling Centertype: taskAn actionable item of workAn actionable item of work
Milestone
Description
Describe the Task
This issue arose during the METplus NOAA telecon on 6/13/2022. @LoganDawson-NOAA requested that we add two new conversion functions to MET's default ConfigConstants file:
M_to_KFT(x) = x * 3.28084 * 0.001;
KM_to_KFT(x) = x * 3280.84 * 0.001;
He references these when doing verification of echo tops, and having them be defined by default is more convenient than hard-coding the functions or re-defining them in each METplus configuration file.
Time Estimate
1 hour
Sub-Issues
Consider breaking the task down into sub-issues.
No sub-issues needed.
Relevant Deadlines
Please fix in both the develop and main_v10.1 branches so that they'd be included in any future bugfix releases.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required: Recommend that @LoganDawson-NOAA review the pull requests.
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Task Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
MET: Configurationpriority: mediumMedium PriorityMedium Priorityrequestor: NOAA/EMCNOAA Environmental Modeling CenterNOAA Environmental Modeling Centertype: taskAn actionable item of workAn actionable item of work