Skip to content

Fix Stat-Analysis to aggregate the ECNT ME and RMSE values correctly. #2170

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Problem

This issue was raised via METplus discussions:
dtcenter/METplus#1632

When aggregating multiple ECNT lines together, Stat-Analysis reports ME = RMSE = 0 in the output even when it should not, based on the inputs.

Expected Behavior

Stat-Analysis -job aggregate -line_type ECNT should correctly compute aggregated ME and RMSE scores rather than always reporting them as 0.

Environment

Describe your runtime environment:
1. Machine: Mac Laptop, but reproducible on any
2. OS: MacOS, but not OS-dependent
3. Software version number(s): Reproduced with MET versions 10.0, 10.1, and the latest in develop

To Reproduce

Describe the steps to reproduce the behavior:
1. Download sample_ecnt.txt
2. Run:

stat_analysis -lookin sample_ecnt.txt -job aggregate -line_type ECNT

3. Observe ME = RMSE = 0 in the output

COL_NAME: TOTAL N_ENS    CRPS CRPSS     IGN ME RMSE  SPREAD ME_OERR RMSE_OERR SPREAD_OERR SPREAD_PLUS_OERR CRPSCL CRPS_EMP CRPSCL_EMP CRPSS_EMP
    ECNT:     2     6 6.88929    NA 5.91505  0    0 7.34208      NA        NA          NA               NA     NA  3.47321         NA        NA

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required: None required.

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions