-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Enhancement
This issue arose via this METplus Discussion. The METplus team recommended that @PerryShafran-NOAA run the pntnc2ascii.R Rscript to dump the NetCDF output from PB2NC prior to interrogating that data further. That script is very useful and really helps with debugging, but it cannot be run on WCOSS or Hera due to R package dependencies.
This task is to reimplement this functionality in Python instead of R, making sure that it uses Python packages actually available on WCOSS and Hera.
The Rscript currently lives in "met/scripts/Rscripts". The python implementation could be stored in "met/scripts/python". However, I'd recommend re-evaluating the final location for this. Does it really belong in the METplus repo? Or perhaps the METdatadb repo after it's been named to METdataio? Or perhaps it does belong in MET, but should be placed in a new "met/scripts/utility" directory?
Recommend removing the old pntnc2ascii.R script once the Python version has replaced it.
Note that the majority of this work is likely already done in read_met_point_obs.py. We could just modify it to provide an option to write the observations to stdout. Or support a "-out" command line option to write the data to an output file.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
No sub-issues needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2773542
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.