-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the Enhancement
When preparing training material for the MET-TC tools and also applying it for the unified physics testing and evaluation project, @KathrynNewman found that the TC-RWM tool does not actually perform the steps that the documentation claims it does. Namely, it does not compute and report tangential and radial winds. Looking at the tc_rmw.cc source code, I agree with her.
While the wind_ne_to_ra() function looks like logic for winds, that function is never actually being called! Instead process_fields() just loops over the requested fields but includes no special logic for handling U and V.
Reading this, tc_rmw chapter of the User's Guide, I agree that the functionally does not match the documentation. This needs more work.
This task is enhance the TC-RMW tool to compute and report tangential and radial winds. Listing @KathrynNewman as an assignee so that she can advise on and help test the development.
Time Estimate
2 days
Sub-Issues
Consider breaking the enhancement down into sub-issues.
No sub-issues needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
2793451 - based on guidance on Kathryn
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.