Skip to content

Enhance the PBL derivation logic in PB2NC. #1913

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Enhancement

This issue is the result of this METplus Discussion dtcenter/METplus#1140.

There was a lot of back and forth on that discussion thread, but in the end, two necessary changes were identified. This issue is to make the following 2 changes to the PBL derivation logic in PB2NC:

(1) In MET version 10.0.0, PB2NC replaces any computed PBL values > 5000 with a value of 5000. Change this behavior by defining the upper limit as 10,000 and replace any values > 10000 with BAD DATA. Note that these bad data observation values should not be written to the output.

(2) Check the input level data for the PBL derivation algorithm and omit any levels that contain non-pyhsical values, namely a pressure value of 0. For an example, see this Discussion comment which includes the following bad input level:

DEBUG 8: compute_pbl()     input to calpbl_: 0   0.00000 0.00000 36893488147419103232.00000 36893488147419103232.00000 -2.29688 1.30000

Time Estimate

1 day.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions