-
Notifications
You must be signed in to change notification settings - Fork 26
Labels
MET: ConfigurationMET: Grid-to-Point Verificationrequestor: UK Met OfficeUnited Kingdom Met OfficeUnited Kingdom Met Officetype: new featureMake it do something newMake it do something new
Milestone
Description
Describe the New Feature
This feature was requested by the UK Met Office via GitHub Discussions.
Recommend the following changes:
- Rename the existing "obs_quality" config option for Point-Stat and Ensemble-Stat as "obs_quality_inc".
- Add a new config option for "obs_quality_exc" to specify which quality strings should be excluded.
- If "obs_quality_inc" is not defined, parse the old "obs_quality" config option and store use its value, for backwards compatibility.
- Be sure that these options are parsed separately for each verification tasks, just like the existing "obs_quality" option is.
- Be sure to update the documentation and unit tests to exercise this.
Acceptance Testing
List input data types and sources.
Describe tests required for new functionality.
Time Estimate
2 days.
Sub-Issues
Consider breaking the new feature down into sub-issues.
No sub-issues needed.
Relevant Deadlines
Needed for the operational use of METplus by the UK Met Office
Funding Source
Met Office Support key: 2799991
Define the Metadata
Assignee
- Select engineer(s) or no engineer required: Seth
- Select scientist(s) or no scientist required: no scientist required but request that the Met Office test the resulting beta release.
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
- METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy
- Define a METplus issue to handle the config option changes for obs_quality_inc and obs_quality_exc: Added support for setting obs_quality_inc/exc in PointStat METplus#1213
New Feature Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
MET: ConfigurationMET: Grid-to-Point Verificationrequestor: UK Met OfficeUnited Kingdom Met OfficeUnited Kingdom Met Officetype: new featureMake it do something newMake it do something new